--via-asm only on windows
#90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nomeata
added a commit
to entropia/tip-toi-reveng
that referenced
this pull request
Mar 15, 2019
andreabedini
pushed a commit
to andreabedini/haskell.nix
that referenced
this pull request
Sep 14, 2022
This mistake was introduced in 8620365. Where previously the (+++) operator from https://hackage.haskell.org/package/Cabal-2.4.1.0/docs/Distribution-Compat-ReadP.html#v:-43--43--43- was used to give no precedence to left or right, now the <|> operator is used instead, which fails if the left fails and won't try the right (non-backtracking). To fix this, a try is used, which explicitly makes the code backtrack if the left was unsuccessful. A better fix would be possible by reading until ':', then change behavior depending on whether "sha256" or "rev" was read
andreabedini
pushed a commit
to andreabedini/haskell.nix
that referenced
this pull request
Sep 14, 2022
This mistake was introduced in e04dbd4. Where previously the (+++) operator from https://hackage.haskell.org/package/Cabal-2.4.1.0/docs/Distribution-Compat-ReadP.html#v:-43--43--43- was used to give no precedence to left or right, now the <|> operator is used instead, which fails if the left fails and won't try the right (non-backtracking). To fix this, a try is used, which explicitly makes the code backtrack if the left was unsuccessful. A better fix would be possible by reading until ':', then change behavior depending on whether "sha256" or "rev" was read
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #86