Update skeleton to cabalProject and overlays, and use nixpkgs19.09 as default #317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angerman
reviewed
Feb 1, 2020
default.nix
Outdated
| , extraOverlays ? nixpkgsOverlays | ||
| , system ? system' | ||
| , globalConfig ? globalConfig' | ||
| , config ? config' | ||
| , crossSystem ? crossSystem' }: import nixpkgs ({ | ||
| overlays = [ jemallocOverlay ] ++ extraOverlays; | ||
| overlays = overlays ++ extraOverlays; |
There was a problem hiding this comment.
Wouldn't we want overlays ++ [ jemallocOverlay ] ++ extraOverlays? lest we loose the jemallocOverlay once someone passes in the overlays arg?
There was a problem hiding this comment.
yeah, though existing behavior is preserved. only a new capacity to set all overlays is added.
There was a problem hiding this comment.
ah also, apparently jemallocOverlay is only useful for 18.03, the new jemalloc version that fix the issue is the default since 18.09.
jbgi
force-pushed
the
update-nixpkgs-haskell-nix
branch
3 times, most recently
from
270e44d to
8b89032
Compare
disassembler
requested changes
Feb 4, 2020
jbgi
force-pushed
the
update-nixpkgs-haskell-nix
branch
8 times, most recently
from
246c48e to
3d49709
Compare
jbgi
force-pushed
the
update-nixpkgs-haskell-nix
branch
from
3d49709 to
46d2fb2
Compare
jbgi
changed the title
jbgi
force-pushed
the
update-nixpkgs-haskell-nix
branch
7 times, most recently
from
98bd2ff to
4e4a658
Compare
jbgi
force-pushed
the
update-nixpkgs-haskell-nix
branch
3 times, most recently
from
c8ef226 to
af3f56b
Compare
sourcesOverride can be use instead of NIX_PATH based overrides.
jbgi
force-pushed
the
update-nixpkgs-haskell-nix
branch
5 times, most recently
from
ce71455 to
6b37241
Compare
jbgi
force-pushed
the
update-nixpkgs-haskell-nix
branch
from
6b37241 to
ff4c98e
Compare
jbgi
changed the title
jbgi
changed the title
|
bors ping |
|
pong |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 7, 2020
317: Update skeleton to cabalProject and overlays, and use nixpkgs19.09 as default r=jbgi a=jbgi Co-authored-by: Jean-Baptiste Giraudeau <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.