Skip to content

[LW-8490] Governance Actions #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Dec 14, 2023
Merged

Conversation

renanvalentin
Copy link
Contributor

@renanvalentin renanvalentin commented Oct 26, 2023

Checklist

TODO:


Proposed solution

Create the UI needed for governance actions

Screenshots

Screenshot 2023-12-12 at 21 23 15 Screenshot 2023-12-12 at 21 26 36 Screenshot 2023-12-12 at 21 28 42 Screenshot 2023-12-12 at 21 43 54 Screenshot 2023-12-12 at 21 20 48

Allure report

allure-report-publisher generated test report!

smokeTests: ❌ test report for e187bf08

passed failed skipped flaky total result
Total 31 1 0 0 32

@github-actions github-actions bot added browser Changes to the browser application. staking Changes to the staking package. ui-toolkit ci CI related issues or pull requests. labels Oct 26, 2023
@renanvalentin renanvalentin changed the base branch from main to feat/sanchonet October 26, 2023 13:04
@renanvalentin renanvalentin force-pushed the feat/proposal-procedure branch from 78c8904 to 3bb7dd9 Compare October 27, 2023 13:43
@github-actions github-actions bot removed the staking Changes to the staking package. label Oct 27, 2023
@renanvalentin renanvalentin force-pushed the feat/proposal-procedure branch from 3bb7dd9 to 8242645 Compare October 30, 2023 14:12
@github-actions github-actions bot added staking Changes to the staking package. ui-toolkit and removed ui-toolkit ci CI related issues or pull requests. labels Oct 30, 2023
@renanvalentin renanvalentin changed the title Feat/proposal procedure [LW-8490] Governance Actions Oct 31, 2023
@renanvalentin renanvalentin self-assigned this Oct 31, 2023
@renanvalentin renanvalentin marked this pull request as ready for review November 7, 2023 13:21
@renanvalentin renanvalentin requested review from a team November 7, 2023 13:21
@mchappell mchappell requested a review from a team as a code owner November 13, 2023 16:46
@vetalcore vetalcore force-pushed the feat/proposal-procedure branch from e187bf0 to b281387 Compare November 28, 2023 14:22
@github-actions github-actions bot added the ci CI related issues or pull requests. label Nov 28, 2023
Copy link

github-actions bot commented Nov 28, 2023

Allure report

allure-report-publisher generated test report!

smokeTests: ❌ test report for fb702314

passed failed skipped flaky total result
Total 1 30 0 0 31

@vetalcore vetalcore force-pushed the feat/proposal-procedure branch 2 times, most recently from c2fa0da to 8a7a55d Compare November 30, 2023 12:36
@vetalcore vetalcore force-pushed the feat/proposal-procedure branch from 8a7a55d to 53a2e93 Compare November 30, 2023 12:52
@vetalcore vetalcore force-pushed the feat/proposal-procedure branch 2 times, most recently from 6315e0e to 8b9016a Compare December 5, 2023 13:20
@vetalcore vetalcore force-pushed the feat/proposal-procedure branch 5 times, most recently from 53005fe to c3ae6d2 Compare December 12, 2023 22:32
@vetalcore vetalcore force-pushed the feat/proposal-procedure branch from c3ae6d2 to 6873487 Compare December 13, 2023 11:22
@vetalcore vetalcore force-pushed the feat/proposal-procedure branch from 1242afa to a1890f3 Compare December 13, 2023 21:01
@coveralls
Copy link

coveralls commented Dec 13, 2023

Coverage Status

Changes unknown
when pulling fb70231 on feat/proposal-procedure
into ** on feat/sanchonet**.

@vetalcore vetalcore force-pushed the feat/proposal-procedure branch from a1890f3 to a0bba1a Compare December 14, 2023 09:50
@vetalcore vetalcore force-pushed the feat/proposal-procedure branch from a0bba1a to fb70231 Compare December 14, 2023 10:08
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

21.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@mchappell mchappell merged commit a7e84ad into feat/sanchonet Dec 14, 2023
@mchappell mchappell deleted the feat/proposal-procedure branch December 14, 2023 11:00
mchappell added a commit that referenced this pull request Mar 6, 2024
…tivity history (#727)

* chore/Bump cardano-js-sdk (#559)

* chore!: bump cardano-js-sdk packages to latest versions

* ci: add cardano services urls parameters to build step

* Feat/sanchonet network switch support (#612)

* feat: update env to support switching to sanchonet

* chore: remove old testnet

* chore: bump cardano-sdk packages to latest version

---------

Co-authored-by: mirceahasegan <[email protected]>

* [LW-7983] [LW-7984] dRep confirmation screens (#554)

* refactor: move logic out of component

* fix: file path

* feat(core): setup storybook

* refactor(ui): extract insufficient funds warning component

* feat(core): add lace/ui package

* feat(core): create ConfirmDRepRegistration component

* feat(extension): install @lace/ui

* refactor: move functions to utils

* fix: type

* refactor: types file

* feat: check for DRep transaction

* feat: integrate confirm drep registration component

* refactor(core): use Metadata component

* refactor(core): use flexbox

* refactor(core): remove insufficient funds message

* refactor(core): create ConfirmDRepRetirement

* refactor: remove insufficient funds warning; break down main component

* feat: add certificate data

* feat: add drep retirement container

* fix: condition

* fix: type

* fix: style

* fix: check for anchor

* fix: check for undefined certificates

* fix: merge conflict

* fix: type error

* feat: temp env changes

* feat(extension): use consistent naming of DRep ID

* feat(extension): show anchor metadata if exists

* feat(extension): convert user facing DRepID to bech32

* fix: add cardano symbol to deposit amount

* chore(core): downgrade storybook to v6

* fix: update lock file

* fix: styles and text

* fix: storybook build

* fix: storybook build

* feat: check retired drep key

* fix: check retired drep key

---------

Co-authored-by: Renan Ferreira <[email protected]>
Co-authored-by: Michael Chappell <[email protected]>

* feat(extension): [LW-7984] voting procedures (#655)

* feat(ui): create metadata component

* wip

* feat(ui): text link component

* chore(ui): fix rebase

* feat(ui): create metadata link component

* feat(core): create voting procedures component

* chore(extension): fix rebase

* fix(ui): add work break

* feat(extension): voting procedures

* refactor(core): make actions optional

* refactor(core): use action as key prop

* refactor(extension): add custom title for voting procedures

* [LW-8491] Voting delegation confirmation (#648)

* feat(core): setup storybook

* feat(core): add lace/ui package

* feat: check for DRep transaction

* feat: integrate confirm drep registration component

* refactor: remove insufficient funds warning; break down main component

* feat: add certificate data

* feat: add drep retirement container

* feat(extension): use consistent naming of DRep ID

* fix: add cardano symbol to deposit amount

* refactor: certificate inspector factory

* feat: voting delegation

* fix: type errors

* fix: merge conflicts

---------

Co-authored-by: Michael Chappell <[email protected]>

* chore: modify sanchonet urls (#667)

* feat: drep update certificate signing (#664)

* fix(extension): updated padding and missing bech32 addressing

* fix: no explorer for sanchonet

* chore(extension): add unit tests for dapp/confirm-tx (#743)

* fix: update drep id casing

* fix: update title translations for cip95 popups

* fix(extension): [LW-9163] nullish check on existence of stakeKeyDeposit property not value (#751)

* fix: e2e no unresolved imports

* chore(extension): resolve pr comments (#748)

* fix(extension): translation keys casing and unit tests (#756)

* chore(all): exclude stories and tests from the rollup builds (#752)

* chore(core): fix extension of stories .ts -> .tsx (impacts: rollup)

* chore(all): exclude test files from rollup builds

* Chore/update for sdk conway era (#734)

* chore: stake pools sort by ros

* chore: metrics require lastRos and ros

* Revert "Chore/update for sdk conway era (#734)" (#767)

This reverts commit 5b81b19.

* test(extension): add test ids for governance actions (#765)

* Merge main into feat/sanchonet (#763)

* feat(staking): maintenance 24 Nov 2023 (#754)

* feat(staking): maintenance 24 Nov 2023

* [LW-9151] Edit account name component (#746)

* feat(ui): input component

* feat(extension): edit account drawer

* feat(extension): add unit test

* feat: rename input component

* feat(ui): use pseudo parameters

* feat(ui): input width

* feat(ui): input disabled style

* feat(extension): add ui package

* feat: update lock file

* feat(ui): remove redundant styles

* feat(extension): [LW-5806] update Minting transaction display from dapps (#608)

* feat: identify minting txs from dapps and display proper UI to confirm

refs: LW-5806

* feat(extension): update dapp transaction styling

* refactor(extension,core): fix sonarcloud quality checks

* ci(core): add @lace/ui to dependencies

* test(extension): add mocks in ConfirmTransaction.test.tsx

* test(extension): remove leftover from local testing

* refactor(core): add missing newline at end of file

---------

Co-authored-by: przemyslaw.wlodek <[email protected]>

* test(extension): maintenance 27 nov (#757)

* test(extension): maintenance nov 27

* test(extension): clear failed request test logs

* test(extension): add real time console test logging, remove unnecessary logs

* test(extension): update wdio version

* test(extension): add node option env variable for e2e github runs

* test(extension): move node options to e2e test sections

* test(extension): increase max-old-space-size

* test(extension): downgrade wdio to stable version, remove node env variable

* feat(staking): [LW-6437, LW-8877] past epochs rewards chart (#718)

---------

Co-authored-by: refi93 <[email protected]>
Co-authored-by: przemyslaw.wlodek <[email protected]>
Co-authored-by: januszjanus <[email protected]>

* feat(extension): track manual re-sync and hd wallet discovery (#712)

* feat(staking): [LW-8929, LW-8777] apply pool search also to selected pools (#706)

---------

Co-authored-by: refi93 <[email protected]>

* feat(staking,common): enable manageDelegation CTA from pool details (#720)

Co-authored-by: przemyslaw.wlodek <[email protected]>

* feat(staking): load multi-delegation for HW wallets (#686)

---------

Signed-off-by: Kamil Džurman <[email protected]>
Co-authored-by: Rafael Korbaš <[email protected]>
Co-authored-by: januszjanus <[email protected]>
Co-authored-by: przemyslaw.wlodek <[email protected]>

* test(extension): test maintenance 29 Nov - fix Dapp e2e (#760)

* feat(extension): [LW-9028] Add wallet concepts to menu (#742)

* feat(extension): update dropdown menu with new wallet component

* feat(extension): add add new wallet option to profile dropdown

* refactor(ui): add test id

* refactor(extension): add test id for multi wallet

* refactor(extension): increase button width to match figma

* refactor(extension): remove copy address tooltip from multi-wallet menu it em

* refactor(extension): align top navigation buttons with side panel

* refactor(extension): update the expand button styling

* refactor(extension): update network pill and expand button styling

* refactor(extension): update network pill border radius

* refactor(extension): limit network pill change to popup only

* fix(extension): fix moving left side bar

* refactor(extension,core,cardano): post-merge fixes

* chore(extension): fix unit tests + rename

* chore(extension): fix unit tests and mocks

* chore(extension): remove TODO comments

* chore(core): review comments

---------

Signed-off-by: Kamil Džurman <[email protected]>
Co-authored-by: Janusz Janus <[email protected]>
Co-authored-by: Lucas <[email protected]>
Co-authored-by: Leonel Gobbi <[email protected]>
Co-authored-by: bslabiak <[email protected]>
Co-authored-by: Tomek Marciniak <[email protected]>
Co-authored-by: refi93 <[email protected]>
Co-authored-by: Kamil Džurman <[email protected]>
Co-authored-by: Lukasz Jagiela <[email protected]>
Co-authored-by: Renan Valentin <[email protected]>

* feat(extension): add drep retirement id mismatch modal (#758)

* chore: update cardano-sdk packages

* refactor: update lace based on cardano-sdk breaking changes

refactor: use internal wallet address discovery

* fix: typos in translation

* feat: stake and vote confirmation screens (#683)

* chore/Bump cardano-js-sdk (#559)

* chore!: bump cardano-js-sdk packages to latest versions

* ci: add cardano services urls parameters to build step

* Feat/sanchonet network switch support (#612)

* feat: update env to support switching to sanchonet

* chore: remove old testnet

* chore: bump cardano-sdk packages to latest version

---------

Co-authored-by: mirceahasegan <[email protected]>

* [LW-7983] [LW-7984] dRep confirmation screens (#554)

* refactor: move logic out of component

* fix: file path

* feat(core): setup storybook

* refactor(ui): extract insufficient funds warning component

* feat(core): add lace/ui package

* feat(core): create ConfirmDRepRegistration component

* feat(extension): install @lace/ui

* refactor: move functions to utils

* fix: type

* refactor: types file

* feat: check for DRep transaction

* feat: integrate confirm drep registration component

* refactor(core): use Metadata component

* refactor(core): use flexbox

* refactor(core): remove insufficient funds message

* refactor(core): create ConfirmDRepRetirement

* refactor: remove insufficient funds warning; break down main component

* feat: add certificate data

* feat: add drep retirement container

* fix: condition

* fix: type

* fix: style

* fix: check for anchor

* fix: check for undefined certificates

* fix: merge conflict

* fix: type error

* feat: temp env changes

* feat(extension): use consistent naming of DRep ID

* feat(extension): show anchor metadata if exists

* feat(extension): convert user facing DRepID to bech32

* fix: add cardano symbol to deposit amount

* chore(core): downgrade storybook to v6

* fix: update lock file

* fix: styles and text

* fix: storybook build

* fix: storybook build

* feat: check retired drep key

* fix: check retired drep key

---------

Co-authored-by: Renan Ferreira <[email protected]>
Co-authored-by: Michael Chappell <[email protected]>

* feat(extension): [LW-7984] voting procedures (#655)

* feat(ui): create metadata component

* wip

* feat(ui): text link component

* chore(ui): fix rebase

* feat(ui): create metadata link component

* feat(core): create voting procedures component

* chore(extension): fix rebase

* fix(ui): add work break

* feat(extension): voting procedures

* refactor(core): make actions optional

* refactor(core): use action as key prop

* refactor(extension): add custom title for voting procedures

* [LW-8491] Voting delegation confirmation (#648)

* feat(core): setup storybook

* feat(core): add lace/ui package

* feat: check for DRep transaction

* feat: integrate confirm drep registration component

* refactor: remove insufficient funds warning; break down main component

* feat: add certificate data

* feat: add drep retirement container

* feat(extension): use consistent naming of DRep ID

* fix: add cardano symbol to deposit amount

* refactor: certificate inspector factory

* feat: voting delegation

* fix: type errors

* fix: merge conflicts

---------

Co-authored-by: Michael Chappell <[email protected]>

* chore: modify sanchonet urls (#667)

* feat: drep update certificate signing (#664)

* feat: stake and vote confirmation screens

* fix: correct capitalisation of DRep ID

* fix: voting translation titles

* feat(extension): update staking credential path

---------

Co-authored-by: Leonel Gobbi <[email protected]>
Co-authored-by: mirceahasegan <[email protected]>
Co-authored-by: Renan Ferreira <[email protected]>
Co-authored-by: Michael Chappell <[email protected]>

* [LW-8490] Governance Actions (#670)

* chore/Bump cardano-js-sdk (#559)

* chore!: bump cardano-js-sdk packages to latest versions

* ci: add cardano services urls parameters to build step

* Feat/sanchonet network switch support (#612)

* feat: update env to support switching to sanchonet

* chore: remove old testnet

* chore: bump cardano-sdk packages to latest version

---------

Co-authored-by: mirceahasegan <[email protected]>

* [LW-7983] [LW-7984] dRep confirmation screens (#554)

* refactor: move logic out of component

* fix: file path

* feat(core): setup storybook

* refactor(ui): extract insufficient funds warning component

* feat(core): add lace/ui package

* feat(core): create ConfirmDRepRegistration component

* feat(extension): install @lace/ui

* refactor: move functions to utils

* fix: type

* refactor: types file

* feat: check for DRep transaction

* feat: integrate confirm drep registration component

* refactor(core): use Metadata component

* refactor(core): use flexbox

* refactor(core): remove insufficient funds message

* refactor(core): create ConfirmDRepRetirement

* refactor: remove insufficient funds warning; break down main component

* feat: add certificate data

* feat: add drep retirement container

* fix: condition

* fix: type

* fix: style

* fix: check for anchor

* fix: check for undefined certificates

* fix: merge conflict

* fix: type error

* feat: temp env changes

* feat(extension): use consistent naming of DRep ID

* feat(extension): show anchor metadata if exists

* feat(extension): convert user facing DRepID to bech32

* fix: add cardano symbol to deposit amount

* chore(core): downgrade storybook to v6

* fix: update lock file

* fix: styles and text

* fix: storybook build

* fix: storybook build

* feat: check retired drep key

* fix: check retired drep key

---------

Co-authored-by: Renan Ferreira <[email protected]>
Co-authored-by: Michael Chappell <[email protected]>

* feat(extension): [LW-7984] voting procedures (#655)

* feat(ui): create metadata component

* wip

* feat(ui): text link component

* chore(ui): fix rebase

* feat(ui): create metadata link component

* feat(core): create voting procedures component

* chore(extension): fix rebase

* fix(ui): add work break

* feat(extension): voting procedures

* refactor(core): make actions optional

* refactor(core): use action as key prop

* refactor(extension): add custom title for voting procedures

* feat(core): create parameter change action

* feat(core): create hard fork initiation action

* feat(core): create new constitution action

* feat(core): create no confidence action

* feat(core): create treasury withdrawals action

* feat(core): create info action

* feat(core): create update comittee action

* refactor(core): check if anchor is provided

* refactor(core): update storybook path

* feat(extension): add translations

* refactor(core): remove ununsed prop

* feat(staking): [LW-8684] add tooltip to piechart (#616)

* feat: lw-8684-add tooltip to delegation piechart

* fix: add custom tooltip dot style

* feat(ui): add tooltip to metadata component

* chore(core): fix pipeline

* chore(core): update proposal procedures components to the latest ui

* fix(extension): resolve pr comments

---------

Co-authored-by: Leonel Gobbi <[email protected]>
Co-authored-by: mirceahasegan <[email protected]>
Co-authored-by: Lucas <[email protected]>
Co-authored-by: Michael Chappell <[email protected]>
Co-authored-by: John Oshalusi <[email protected]>
Co-authored-by: Vitalii Vozniak <[email protected]>

* fix(extension): resolve pr comments

* fix(extension): remove code duplications for metadata and metadata link components

* feat(extension): lw-8600 (#819)

* feat(extension): lw-8600

* feat(extension): fix translations

* feat(extension): fix tx details mappers

* fix(extension): lw-8600 move helpers to common util

* fix(extension): resolve pr comment

* fix(extension): unify tx details lists

* fix(extension): resolve sdet comments

* fix(extension): resolve sdet comments

* refactor: remove need to target dev endpoints in CI

* refactor: remove sanchonet as default network option

* refactor: remove sanchonet explorer check

* feat(extension): update drep mapper check

* fix(extension): conway-era tx activities line items (#860)

* fix(extension): conway-era tx activiries line items

* fix(extension): adjust tests

* fix(extension): resolve pr comments

* feat(extension): update drep mapper check

* fix(extension): convert drepid and stakekeyhash to bech32, fix translations

* fix(extension): lw-9688: unable to see transaction details for conway-era transactions

* fix(extension): resolve lw-9621 pe comments

* fix(extension): resolve lw-9621 pr comments

* fix(extension): lw-9621 add storybook showing all conway era governance activity items

* chore(core): fix storybook build

* fix: use correct stake address bech32

* fix(core): sanchonet-related storybook errors [LW-9721] (#880)

* fix(core): add custom viewports and proper structure to storybook

* fix(core): react key prop errors

* refactor: rename useCexplorerBaseUrl typo

* fix: add storybook back for core package

* feat: update stories for conway-era tx activity history

* fix: add retry fallback for matching last active tab based on non-standard URL

* chore: update dev preview env file

* feat(extension): update conway era tx details to the latest figma (#868)

* feat(extension): update conway era tx details to the latest figma

* feat(extension): handle multiline row items with subitems

* feat(extension): handle parameter_change_action

* fix(extension): resolve pr comments

* fix(extension): update to the latest figma/AC

* fix(extension): resolve pr comments

* fix(extension): resolve sanchonet pr comments

* fix(extension): after merge with sanchonet fixes

* fix(extension): after merge with sanchonet fixes

* fix(extension): resolve sanchonet pr comments

* chore(core): mock @lace/cardano for storybook

* fix(extension): fix tests

* chore: downgrade uuid package to same used by pouchdb

* refactor: remove unintended config changes

* fix: no wallet dapp test

* fix(extension): resolve lw-9622 sdet comments

* feat(extension): update conway era history line items

* fix(extension): make anchor url clickable

* fix(extension): resolve pr comments

* fix: lw-8940 casing in reward account

* feat(extension): update sign with hw

* chore: reword stakeVoteDelegation title

* feat(extension): handle requests from non registered users (#935)

* feat(extension): handle requests from non registered users

* feat(extension): fix modal visibility condition

* feat(extension): fix test

* fix(extension): resolve pr comments

* fix(extension): fix labels

* refactor: rename proprosal procedure call

* fix: broken hook test

* feat: revert useTxSummary hook

* feat(extension): fix test

* refactor: revert story change

---------

Signed-off-by: Kamil Džurman <[email protected]>
Co-authored-by: Leonel Gobbi <[email protected]>
Co-authored-by: mirceahasegan <[email protected]>
Co-authored-by: Lucas <[email protected]>
Co-authored-by: Renan Ferreira <[email protected]>
Co-authored-by: vetalcore <[email protected]>
Co-authored-by: Przemysław Włodek <[email protected]>
Co-authored-by: Wojtek Kłos <[email protected]>
Co-authored-by: Janusz Janus <[email protected]>
Co-authored-by: bslabiak <[email protected]>
Co-authored-by: Tomek Marciniak <[email protected]>
Co-authored-by: refi93 <[email protected]>
Co-authored-by: Kamil Džurman <[email protected]>
Co-authored-by: Lukasz Jagiela <[email protected]>
Co-authored-by: John Oshalusi <[email protected]>
Co-authored-by: wklos-iohk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser Changes to the browser application. ci CI related issues or pull requests. staking Changes to the staking package.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants