Skip to content

feat(staking): maintenance 24 Nov 2023 #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 27, 2023
Merged

feat(staking): maintenance 24 Nov 2023 #754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1cbde0
feat(staking): maintenance 24 Nov 2023
oldGreg5 Nov 24, 2023
8132107
feat(staking): cleanup
oldGreg5 Nov 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/e2e-tests/src/features/EmptyStatesExtended.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ Feature: Empty states

@LW-8447
Scenario: Extended View - Staking empty state
When I disable showing Multidelegation beta banner
And I navigate to Staking extended page
Then I see empty state banner for Staking page in extended mode
When I click "Copy" button on empty state banner
Expand Down
1 change: 0 additions & 1 deletion packages/e2e-tests/src/features/EmptyStatesPopup.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ Feature: Empty states

@LW-8470
Scenario: Popup View - Staking empty state
When I disable showing Multidelegation beta banner
And I navigate to Staking popup page
Then I see empty state banner for Staking page in popup mode
When I click "Copy" button on empty state banner
Expand Down
1 change: 0 additions & 1 deletion packages/e2e-tests/src/features/FullExperiencePopup.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ Feature: Full experience - popup view

@LW-3446
Scenario Outline: Popup View - <page> opened - "Expand" button click
Given I disable showing Multidelegation beta banner
And I am on <page> popup page
When I click on "Expand" button
Then the <page> page is displayed on a new tab in extended view
Expand Down
12 changes: 0 additions & 12 deletions packages/e2e-tests/src/features/MultiDelegationPageExtended.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ Feature: Staking Page - Extended View
@LW-8931 @Testnet
Scenario: Extended View - Start Staking component
Given I save token: "Cardano" balance
And I disable showing Multidelegation beta banner
When I navigate to Staking extended page
Then I see Start Staking page in extended mode

Expand All @@ -23,14 +22,12 @@ Feature: Staking Page - Extended View

@LW-8449 @Testnet @Mainnet
Scenario: Extended View - Staking search control is displayed with appropriate content
Given I disable showing Multidelegation beta banner
When I navigate to Staking extended page
And I click Browse pools tab
Then I see the stake pool search control with appropriate content

@LW-8448 @Testnet
Scenario Outline: Extended View - Stake pool search for "<stake_pool_search_term>" returns the expected number of results <number_of_results> with appropriate content
Given I disable showing Multidelegation beta banner
When I navigate to Staking extended page
And I click Browse pools tab
And I input "<stake_pool_search_term>" into stake pool search bar
Expand All @@ -49,7 +46,6 @@ Feature: Staking Page - Extended View

@LW-8448 @Mainnet
Scenario Outline: Extended View - Stake pool search for "<stake_pool_search_term>" returns the expected number of results <number_of_results> with appropriate content
Given I disable showing Multidelegation beta banner
When I navigate to Staking extended page
And I click Browse pools tab
And I input "<stake_pool_search_term>" into stake pool search bar
Expand All @@ -69,12 +65,10 @@ Feature: Staking Page - Extended View
@LW-8466 @Testnet @Mainnet
Scenario: Extended View - "About staking" widget
Given I am on Staking extended page
And I close Multi-delegation beta modal
Then I see "About staking" widget with all relevant items

@LW-8465 @Testnet @Mainnet
Scenario Outline: Extended View - "About staking" widget item click - <subtitle>
Given I disable showing Multidelegation beta banner
And I am on Staking extended page
When I click on a widget item with subtitle: "<subtitle>"
Then I see a "<type>" article with title "<subtitle>"
Expand All @@ -87,13 +81,11 @@ Feature: Staking Page - Extended View

@LW-8469 @Testnet @Mainnet
Scenario: Extended View - Network info component is present with expected content
Given I disable showing Multidelegation beta banner
When I navigate to Staking extended page
Then I see the Network Info component with the expected content

@LW-8499 @Testnet @Mainnet
Scenario Outline: Extended View - Staking - Show tooltip for column names in browse pools section
Given I disable showing Multidelegation beta banner
When I navigate to Staking extended page
And I click Browse pools tab
When I hover over "<column_name>" column name in stake pool list
Expand All @@ -105,7 +97,6 @@ Feature: Staking Page - Extended View

@LW-8637 @Testnet @Mainnet
Scenario: Extended View - Staking password screen details
Given I disable showing Multidelegation beta banner
When I navigate to Staking extended page
And I click Overview tab
And I click Browse pools tab
Expand All @@ -118,7 +109,6 @@ Feature: Staking Page - Extended View

@LW-8445 @Testnet
Scenario: Extended View - Selecting stakepool from list opens drawer with appropriate details
Given I disable showing Multidelegation beta banner
And I am on Staking extended page
And I click Browse pools tab
And I input "ADA Capital" into stake pool search bar
Expand All @@ -127,7 +117,6 @@ Feature: Staking Page - Extended View

@LW-8438 @Testnet
Scenario: Extended View - Staking - Stakepool details drawer - Close drawer
Given I disable showing Multidelegation beta banner
And I am on Staking extended page
And I click Browse pools tab
And I input "ADA Capital" into stake pool search bar
Expand All @@ -137,7 +126,6 @@ Feature: Staking Page - Extended View

@LW-8463 @Testnet @Mainnet
Scenario: Extended View - Stake pool list item
Given I disable showing Multidelegation beta banner
And I am on Staking extended page
And I click Browse pools tab
And I wait for stake pool list to be populated
Expand Down
1 change: 0 additions & 1 deletion packages/e2e-tests/src/features/MultiDelegationPagePopup.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ Feature: Staking Page - Popup View
@LW-8933 @Testnet
Scenario: Popup View - Start Staking component
Given I save token: "Cardano" balance
And I disable showing Multidelegation beta banner
When I navigate to Staking popup page
Then I see Start Staking page in popup mode

Expand Down
2 changes: 0 additions & 2 deletions packages/e2e-tests/src/features/MultidelegationDelegatedFundsExtended.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ Feature: Staking Page - Extended View

@LW-8436 @LW-8439 @LW-8440 @LW-8598
Scenario Outline: Extended View - Staking - Close drawer
Given I disable showing Multidelegation beta banner
When I navigate to Staking extended page
And I click Browse pools tab
And I pick "1" pools for delegation from browse pools view: "ADA Capital"
Expand All @@ -28,7 +27,6 @@ Feature: Staking Page - Extended View

@LW-8450
Scenario Outline: Extended View - Staking - Hover over currently staking element: <element>
Given I disable showing Multidelegation beta banner
And I navigate to Staking extended page
When I hover over <element> in currently staking component
Then I see tooltip for element in currently staking component
Expand Down
11 changes: 4 additions & 7 deletions packages/e2e-tests/src/features/MultidelegationDelegatedFundsPopup.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,14 @@ Feature: Staking Page - Popup View
@LW-8330
Scenario Outline: Popup View - Delegation card displays correct data
Given I open wallet: "<walletName>" in: popup mode
And I disable showing Multidelegation beta banner
And I disable showing Multidelegation persistence banner
When I navigate to Staking popup page
Then I see Delegation title displayed for multidelegation
And I see Delegation card displaying correct data
Examples:
| walletName |
| MultidelegationDelegatedSingle |
| MultidelegationDelegatedMulti |
| walletName |
| MultidelegationDelegatedSingle |
| MultidelegationDelegatedMulti |

@LW-8338
Scenario Outline: Popup View - Delegated pools cards are present
Expand All @@ -31,9 +30,7 @@ Feature: Staking Page - Popup View

@LW-8480
Scenario Outline: Popup View - Staking - Hover over currently staking element: <element>
Given Lace is ready for test
And I disable showing Multidelegation beta banner
And I navigate to Staking popup page
Given I navigate to Staking popup page
When I hover over <element> in currently staking component
Then I see tooltip for element in currently staking component
Examples:
Expand Down
15 changes: 7 additions & 8 deletions packages/e2e-tests/src/features/NavigationMainExtended.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ Feature: Main Navigation - Extended view

Background:
Given Lace is ready for test
And I disable showing Multidelegation beta banner

@LW-2692 @Smoke
Scenario: Extended view - Main navigation is displayed with all items
Expand Down Expand Up @@ -38,13 +37,13 @@ Feature: Main Navigation - Extended view
When I click on the logo icon
Then I see Tokens counter with total number of tokens displayed
Examples:
| section | validateIfSectionIsDisplayed |
| Tokens | I see Tokens counter with total number of tokens displayed |
| NFTs | I see NFTs counter with total number of NFTs displayed |
| Transactions | Transactions section is displayed |
| Staking | I see Delegation title displayed for multidelegation |
| Settings | I see settings page |
| Address Book | I see address book title |
| section | validateIfSectionIsDisplayed |
| Tokens | I see Tokens counter with total number of tokens displayed |
| NFTs | I see NFTs counter with total number of NFTs displayed |
| Transactions | Transactions section is displayed |
| Staking | I see Delegation title displayed for multidelegation |
| Settings | I see settings page |
| Address Book | I see address book title |

@LW-6662
Scenario Outline: Extended view - Main Navigation - Right side panel not displayed in <section> section
Expand Down
1 change: 0 additions & 1 deletion packages/e2e-tests/src/features/NavigationMainPopup.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ Feature: Main Navigation - Popup View
@LW-2610
Scenario Outline: Extended view - Click Lace logo - <section>
And Wallet is synced
And I disable showing Multidelegation beta banner
And I navigate to <section> popup page
And <validateIfSectionIsDisplayed>
When I click on the logo icon
Expand Down
1 change: 0 additions & 1 deletion packages/e2e-tests/src/features/e2e/MultidelegationSwitchingPoolsExtendedE2E.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ Feature: Staking Page - Switching pools - Extended Browser View - E2E

Background:
Given Wallet is synced
And I disable showing Multidelegation beta banner
And I navigate to Staking extended page

@LW-7819 @Testnet @Pending
Expand Down
63 changes: 36 additions & 27 deletions packages/e2e-tests/src/hooks/beforeTagHooks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,22 +30,31 @@ Before(
{
tags: '@AddressBook-extended or @Transactions-Extended or @Tokens-extended or @Staking-Extended or @LockWallet-extended or @Top-Navigation-Extended or @NFTs-Extended or @NFT-Folders-Extended or @SendTx-Bundles-Extended or @SendTx-Simple-Extended or @MainNavigation-Extended or @Send-Transaction-Metadata-Extended or @Settings-Extended or @DAppConnector or @DAppConnector-Extended'
},
async () => await extendedViewWalletInitialization()
async () => {
await extendedViewWalletInitialization();
await localStorageInitializer.disableShowingMultidelegationBetaBanner();
}
);

Before(
{
tags: '@Tokens-popup or @Transactions-Popup or @Staking-Popup or @LockWallet-popup or @Top-Navigation-Popup or @AddressBook-popup or @Common-Popup or @SendTx-Simple-Popup or @MainNavigation-Popup or @Settings-Popup or @NFTs-Popup or @NFT-Folders-Popup or @Send-Transaction-Metadata-Popup or @ForgotPassword or @DAppConnector-Popup'
},
async () => await popupViewWalletInitialization()
async () => {
await popupViewWalletInitialization();
await localStorageInitializer.disableShowingMultidelegationBetaBanner();
}
);

Before(
{ tags: '@EmptyStates-Extended' },
async () => await extendedViewWalletInitialization(TestWalletName.TAWalletNoFunds)
);
Before({ tags: '@EmptyStates-Extended' }, async () => {
await extendedViewWalletInitialization(TestWalletName.TAWalletNoFunds);
await localStorageInitializer.disableShowingMultidelegationBetaBanner();
});

Before({ tags: '@EmptyStates-Popup' }, async () => await popupViewWalletInitialization(TestWalletName.TAWalletNoFunds));
Before({ tags: '@EmptyStates-Popup' }, async () => {
await popupViewWalletInitialization(TestWalletName.TAWalletNoFunds);
await localStorageInitializer.disableShowingMultidelegationBetaBanner();
});

Before(
{ tags: '@SendTx-MultipleSelection-Popup' },
Expand Down Expand Up @@ -104,15 +113,15 @@ Before(
async () => await extendedViewWalletInitialization(TestWalletName.TAWalletDelegatedFunds)
);

Before(
{ tags: '@Staking-NonDelegatedFunds-Extended' },
async () => await extendedViewWalletInitialization(TestWalletName.TAWalletNonDelegatedFunds)
);
Before({ tags: '@Staking-NonDelegatedFunds-Extended' }, async () => {
await extendedViewWalletInitialization(TestWalletName.TAWalletNonDelegatedFunds);
await localStorageInitializer.disableShowingMultidelegationBetaBanner();
});

Before(
{ tags: '@Staking-NonDelegatedFunds-Popup' },
async () => await popupViewWalletInitialization(TestWalletName.TAWalletNonDelegatedFunds)
);
Before({ tags: '@Staking-NonDelegatedFunds-Popup' }, async () => {
await popupViewWalletInitialization(TestWalletName.TAWalletNonDelegatedFunds);
await localStorageInitializer.disableShowingMultidelegationBetaBanner();
});

Before(
{ tags: '@Staking-SwitchingPools-Extended-E2E' },
Expand All @@ -126,10 +135,10 @@ Before(

Before({ tags: '@AdaHandle-popup' }, async () => await popupViewWalletInitialization(TestWalletName.WalletAdaHandle));

Before(
{ tags: '@Multidelegation-SwitchingPools-Extended-E2E' },
async () => await extendedViewWalletInitialization(TestWalletName.WalletMultidelegationSwitchPoolsE2E)
);
Before({ tags: '@Multidelegation-SwitchingPools-Extended-E2E' }, async () => {
await extendedViewWalletInitialization(TestWalletName.WalletMultidelegationSwitchPoolsE2E);
await localStorageInitializer.disableShowingMultidelegationBetaBanner();
});

Before(
{ tags: '@HdWallet-extended' },
Expand All @@ -141,12 +150,12 @@ Before(
async () => await extendedViewWalletInitialization(TestWalletName.WalletSendNftHdWalletE2E)
);

Before(
{ tags: '@Multidelegation-DelegatedFunds-Popup' },
async () => await popupViewWalletInitialization(TestWalletName.MultidelegationDelegatedSingle)
);
Before({ tags: '@Multidelegation-DelegatedFunds-Popup' }, async () => {
await popupViewWalletInitialization(TestWalletName.MultidelegationDelegatedSingle);
await localStorageInitializer.disableShowingMultidelegationBetaBanner();
});

Before(
{ tags: '@Multidelegation-DelegatedFunds-Extended' },
async () => await extendedViewWalletInitialization(TestWalletName.MultidelegationDelegatedSingle)
);
Before({ tags: '@Multidelegation-DelegatedFunds-Extended' }, async () => {
await extendedViewWalletInitialization(TestWalletName.MultidelegationDelegatedSingle);
await localStorageInitializer.disableShowingMultidelegationBetaBanner();
});