Skip to content

Enhance STM library readability - Deprecate Old Structs #2629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 4, 2025
Merged

Enhance STM library readability - Deprecate Old Structs #2629

merged 3 commits into from
Jul 4, 2025
+201 −162

Conversation

curiecrypt
Copy link
Collaborator

@curiecrypt curiecrypt commented Jul 2, 2025 •
edited
Loading

Content

Deprecate old struct names.

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • No new TODOs introduced

Comments

Issue(s)

Relates to #2568

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2025 •
edited
Loading

Test Results

    4 files  ±0    154 suites  ±0   22m 15s ⏱️ +42s
2 071 tests ±0  2 071 ✅ ±0  0 💤 ±0  0 ❌ ±0 
6 356 runs  ±0  6 356 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a5b7cc1. ± Comparison against base commit 81d08dc.

♻️ This comment has been updated with latest results.

jpraynaud
jpraynaud reviewed Jul 2, 2025
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the version since deprecation is not the good one.

Otherwise looks good 👍

@curiecrypt curiecrypt temporarily deployed to testing-preview July 2, 2025 16:18 — with GitHub Actions Inactive
@curiecrypt curiecrypt force-pushed the curiecrypt/deprecate-old-structs branch from 4d21738 to ad955ae Compare July 2, 2025 16:25
@curiecrypt curiecrypt temporarily deployed to testing-preview July 2, 2025 16:46 — with GitHub Actions Inactive
@curiecrypt curiecrypt marked this pull request as ready for review July 2, 2025 16:47
@curiecrypt curiecrypt requested a review from jpraynaud July 2, 2025 16:47
jpraynaud
jpraynaud approved these changes Jul 3, 2025
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@curiecrypt curiecrypt force-pushed the curiecrypt/deprecate-old-structs branch from 366ff1d to a5b7cc1 Compare July 4, 2025 12:14
@curiecrypt curiecrypt temporarily deployed to testing-preview July 4, 2025 12:24 — with GitHub Actions Inactive
@curiecrypt curiecrypt merged commit 6833d2f into main Jul 4, 2025
41 checks passed
@curiecrypt curiecrypt deleted the curiecrypt/deprecate-old-structs branch July 4, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@curiecrypt @jpraynaud