Skip to content

fix(dmq): add missing KES period in 'DmqMsg' #2636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 16, 2025
Merged

fix(dmq): add missing KES period in 'DmqMsg' #2636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
22192ec
chore(dmq): update 'pallas-network' dependency
jpraynaud Jul 15, 2025
373dc1d
fix(dmq): add missing KES period in 'DmqMsg'
jpraynaud Jul 15, 2025
841640e
chore: upgrade crate versions
jpraynaud Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion internal/mithril-dmq/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[package]
name = "mithril-dmq"
description = "Mechanisms to publish and consume messages of a 'Decentralized Message Queue network' through a DMQ node"
version = "0.1.2"
version = "0.1.3"
authors.workspace = true
documentation.workspace = true
edition.workspace = true
Expand Down
2 changes: 2 additions & 0 deletions internal/mithril-dmq/src/consumer/pallas.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,7 @@ mod tests {
32, 32, 253, 186, 201, 177, 11, 117, 135, 187, 167, 181, 188, 22, 59, 206, 105,
231, 150, 215, 30, 78, 212, 76, 16, 252, 180, 72, 134, 137, 247, 161, 68,
],
kes_period: 10,
},
DmqMsg {
msg_id: vec![1, 2],
Expand All @@ -195,6 +196,7 @@ mod tests {
240, 103, 245, 159, 147, 177, 110, 58, 248, 115, 58, 152, 138, 220, 35, 65,
245, 200,
],
kes_period: 11,
},
]
}
Expand Down
9 changes: 9 additions & 0 deletions internal/mithril-dmq/src/message.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ impl DmqMessageBuilder {
hasher.update(dmq_message.ttl.to_be_bytes());
hasher.update(&dmq_message.kes_signature);
hasher.update(&dmq_message.operational_certificate);
hasher.update(dmq_message.kes_period.to_be_bytes());

hasher.finalize().to_vec()
}
Expand All @@ -66,13 +67,20 @@ impl DmqMessageBuilder {
.kes_signer
.sign(message_bytes, block_number)
.with_context(|| "Failed to KES sign message while building DMQ message")?;
let kes_period = self
.chain_observer
.get_current_kes_period(&operational_certificate)
.await
.with_context(|| "Failed to get KES period while building DMQ message")?
.unwrap_or_default();
let mut dmq_message = DmqMsg {
msg_id: vec![],
msg_body: message_bytes.to_vec(),
block_number,
ttl: self.ttl_blocks,
kes_signature: kes_signature.to_bytes_vec()?,
operational_certificate: operational_certificate.to_bytes_vec()?,
kes_period,
};
dmq_message.msg_id = compute_msg_id(&dmq_message);

Expand Down Expand Up @@ -134,6 +142,7 @@ mod tests {
ttl: 100,
kes_signature: kes_signature.to_bytes_vec().unwrap(),
operational_certificate: operational_certificate.to_bytes_vec().unwrap(),
kes_period: 0,
},
DmqMsg {
msg_id: vec![],
Expand Down