Skip to content

Conversation

donyunardi
Copy link
Contributor

Fixes the partial argument match warning message from integration test.

Log
══ Warnings ════════════════════════════════════════════════════════════════════
  ── Warning ('test-verbatim_popup_ui.R:27:3'): verbatim_popup_ui returns `shiny.tag.list` ──
  partial argument match of 'style' to 'stylesheet'
  Backtrace:1. ├─testthat::expect_s3_class(verbatim_popup_ui("STH", "STH2"), "shiny.tag.list") at test-verbatim_popup_ui.R:27:3
   2. │ └─testthat::quasi_label(enquo(object), arg = "object")
   3. │   └─rlang::eval_bare(expr, quo_get_env(quo))
   4. └─teal.widgets::verbatim_popup_ui("STH", "STH2")
   5.   ├─shiny::tagList(...)
   6.   │ └─rlang::dots_list(...)
   7.   └─teal.widgets:::verbatim_popup_deps()
  ── Warning ('test-verbatim_popup_ui.R:38:5'): e2e: teal.widgets::verbatim_popup is initialized with a button that opens a modal with a verbatim text ──
  partial argument match of 'style' to 'stylesheet'
  Backtrace:1. ├─shinytest2::AppDriver$new(...) at test-verbatim_popup_ui.R:38:5
    2. │ └─shinytest2 (local) initialize(...)
    3. │   └─shinytest2:::app_initialize(...)
    4. │     ├─base::withCallingHandlers(...)
    5. │     └─shinytest2:::app_initialize_(self, private, ..., view = view)
    6. │       └─shiny::is.shiny.appobj(app_dir)
    7. └─teal.widgets (local) app_driver_vpu(...)
    8.   ├─shiny::shinyApp(...) at test-verbatim_popup_ui.R:8:3
    9.   │ └─shiny:::uiHttpHandler(ui, uiPattern)
   10.   │   └─base::force(ui)
   11.   ├─bslib::page_fluid(verbatim_popup_ui(id = "verbatim_popup", button_label = button_label))
   12.   │ ├─bslib:::as_page(...)
   13.   │ └─shiny::fluidPage(...)
   14.   │   ├─shiny::bootstrapPage(...)
   15.   │   │ └─rlang::list2(...)
   16.   │   └─htmltools::div(class = "container-fluid", ...)
   17.   │     └─rlang::dots_list(...)
   18.   └─teal.widgets::verbatim_popup_ui(id = "verbatim_popup", button_label = button_label)
   19.     ├─shiny::tagList(...)
   20.     │ └─rlang::dots_list(...)
   21.     └─teal.widgets:::verbatim_popup_deps()
  ── Warning ('test-verbatim_popup.R:91:3'): verbatim_popup_ui returns a tag list ──
  partial argument match of 'style' to 'stylesheet'
  Backtrace:1. ├─testthat::expect_true(...) at test-verbatim_popup.R:91:3
   2. │ └─testthat::quasi_label(enquo(object), label, arg = "object")
   3. │   └─rlang::eval_bare(expr, quo_get_env(quo))
   4. ├─base::inherits(...)
   5. └─teal.widgets::verbatim_popup_ui(id = "test_id", button_label = "Test button label")
   6.   ├─shiny::tagList(...)
   7.   │ └─rlang::dots_list(...)
   8.   └─teal.widgets:::verbatim_popup_deps()
  ── Warning ('test-verbatim_popup.R:97:3'): verbatim_popup_ui with type not equal to 'button' or 'link' throws error ──
  partial argument match of 'style' to 'stylesheet'
  Backtrace:1. ├─testthat::expect_error(...) at test-verbatim_popup.R:97:3
   2. │ └─testthat:::quasi_capture(...)
   3. │   ├─testthat (local) .capture(...)
   4. │   │ └─base::withCallingHandlers(...)
   5. │   └─rlang::eval_bare(quo_get_expr(.quo), quo_get_env(.quo))
   6. └─teal.widgets::verbatim_popup_ui(...)
   7.   ├─shiny::tagList(...)
   8.   │ └─rlang::dots_list(...)
   9.   └─teal.widgets:::verbatim_popup_deps()
  ── Warning ('test-verbatim_popup.R:104:3'): verbatim_popup_ui with type 'button' produces a button ──
  partial argument match of 'style' to 'stylesheet'
  Backtrace:1. └─teal.widgets::verbatim_popup_ui(...) at test-verbatim_popup.R:104:3
   2.   ├─shiny::tagList(...)
   3.   │ └─rlang::dots_list(...)
   4.   └─teal.widgets:::verbatim_popup_deps()
  ── Warning ('test-verbatim_popup.R:109:3'): verbatim_popup_ui with type 'link' produces a button with a class link ──
  partial argument match of 'style' to 'stylesheet'
  Backtrace:1. └─teal.widgets::verbatim_popup_ui(...) at test-verbatim_popup.R:109:3
   2.   ├─shiny::tagList(...)
   3.   │ └─rlang::dots_list(...)
   4.   └─teal.widgets:::verbatim_popup_deps()

@donyunardi donyunardi requested a review from a team August 14, 2025 07:18
@donyunardi donyunardi enabled auto-merge (squash) August 14, 2025 07:18
Copy link
Contributor

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  --------------------------------------------------
R/basic_table_args.R             23       0  100.00%
R/draggable_buckets.R            87      87  0.00%    4-163
R/get_dt_rows.R                  13      13  0.00%    44-56
R/ggplot2_args.R                 49       0  100.00%
R/nested_closeable_modal.R       20      20  0.00%    83-103
R/optionalInput.R               255     212  16.86%   140-438, 501, 562, 568, 583-596
R/panel_group.R                  39      39  0.00%    50-136
R/plot_with_settings.R          309      16  94.82%   299-305, 327, 364, 373-374, 390, 578-579, 581, 583
R/standard_layout.R              52      20  61.54%   81-99, 106
R/table_with_settings.R         158       1  99.37%   100
R/utils.R                         7       0  100.00%
R/verbatim_popup.R              105      52  50.48%   72-87, 113-114, 116, 124-155, 176
R/white_small_well.R              7       7  0.00%    19-25
TOTAL                          1124     467  58.45%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: e442487

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Aug 14, 2025

Unit Tests Summary

  1 files   16 suites   1m 50s ⏱️
124 tests 124 ✅ 0 💤 0 ❌
328 runs  328 ✅ 0 💤 0 ❌

Results for commit e442487.

♻️ This comment has been updated with latest results.

Copy link
Contributor

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
draggable_buckets 💚 $8.47$ $-8.19$ $-2$ $+3$ $0$ $0$
get_dt_rows_ui 💚 $2.83$ $-2.80$ $-4$ $+1$ $0$ $0$
nested_closeable_modal_ui 💚 $2.85$ $-2.85$ $-6$ $+1$ $0$ $0$
optionalSelectInput_ui 💚 $2.86$ $-2.85$ $-14$ $+1$ $0$ $0$
optionalSliderInputValMinMax_ui 💚 $2.35$ $-2.33$ $-1$ $+1$ $0$ $0$
plot_with_settings_ui 💚 $49.06$ $-48.87$ $-30$ $+11$ $0$ $0$
table_with_settings_ui 💚 $32.65$ $-32.51$ $-47$ $+8$ $0$ $0$
verbatim_popup_ui 💚 $3.50$ $-3.48$ $-7$ $+1$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
draggable_buckets 💚 $2.40$ $-2.30$ e2e_teal.widgets_draggable_buckets_initializes_with_default_inputs
draggable_buckets 💚 $3.15$ $-3.03$ e2e_teal.widgets_draggable_buckets_initializes_without_input
draggable_buckets 💚 $2.92$ $-2.86$ e2e_teal.widgets_draggable_buckets_moving_elements_between_buckets_updates_input
get_dt_rows_ui 💚 $2.83$ $-2.80$ e2e_teal.widgets_get_dt_rows_rows_are_settable_and_visible
nested_closeable_modal_ui 💚 $2.85$ $-2.85$ e2e_teal.widgets_nested_closeable_modal_initializes
optionalSelectInput_ui 💚 $2.86$ $-2.85$ e2e_teal.widgets_optionalSelectInput_initializes
optionalSliderInputValMinMax_ui 💚 $2.35$ $-2.33$ e2e_teal.widgets_optionalSliderInputValMinMax_initializes
plot_with_settings_ui 💚 $4.12$ $-4.09$ e2e_teal.widgets_plot_with_settings_buttons_have_proper_FA_icons_and_two_of_them_are_dropdowns
plot_with_settings_ui 💚 $3.87$ $-3.85$ e2e_teal.widgets_plot_with_settings_clicking_download_download_button_downloads_image_in_a_specified_format
plot_with_settings_ui 💚 $4.68$ $-4.66$ e2e_teal.widgets_plot_with_settings_expanded_image_can_be_downloaded
plot_with_settings_ui 💚 $7.48$ $-7.46$ e2e_teal.widgets_plot_with_settings_expanded_image_can_be_resized
plot_with_settings_ui 💚 $3.04$ $-3.04$ e2e_teal.widgets_plot_with_settings_initializes_with_a_plot_and_the_settings_buttons
plot_with_settings_ui 💚 $3.25$ $-3.24$ e2e_teal.widgets_plot_with_settings_it_is_possible_to_set_height_and_width_for_the_plot_on_the_third_button_dropdown_menu_without_errors
plot_with_settings_ui 💚 $4.54$ $-4.53$ e2e_teal.widgets_plot_with_settings_main_image_can_be_resized
plot_with_settings_ui 💚 $5.14$ $-5.13$ e2e_teal.widgets_plot_with_settings_scrollbar_appears_when_image_is_resized
plot_with_settings_ui 💚 $4.12$ $-4.11$ e2e_teal.widgets_plot_with_settings_the_click_on_the_download_button_in_expand_modal_opens_a_download_dropdown
plot_with_settings_ui 💚 $4.32$ $-4.30$ e2e_teal.widgets_plot_with_settings_the_click_on_the_expand_button_opens_an_overlay_plot_height_plot_width_plot_download_dropdown_and_dismiss_button
plot_with_settings_ui 💚 $4.48$ $-4.47$ e2e_teal.widgets_plot_with_settings_the_click_on_the_resize_button_opens_a_dropdown_menu_plot_height_plot_width_plot_download_dropdown_and_dismiss_button
table_with_settings_ui 💚 $4.37$ $-4.35$ e2e_teal.widgets_table_with_settings_check_pagination_appearance_for_.txt_and_disappearance_for_.csv_for_the_first_button
table_with_settings_ui 💚 $4.27$ $-4.25$ e2e_teal.widgets_table_with_settings_check_pagination_appearance_for_.txt_and_disappearance_for_.csv_for_the_modal_on_the_second_button
table_with_settings_ui 💚 $3.89$ $-3.87$ e2e_teal.widgets_table_with_settings_clicking_download_download_button_downloads_table_in_a_specified_format
table_with_settings_ui 💚 $4.50$ $-4.48$ e2e_teal.widgets_table_with_settings_clicking_download_in_an_expand_modal_opens_dropdown_menu_with_dwnl_settings_such_as_file_type_file_name_pagination
table_with_settings_ui 💚 $4.39$ $-4.37$ e2e_teal.widgets_table_with_settings_expanded_table_can_be_downloaded
table_with_settings_ui 💚 $3.05$ $-3.05$ e2e_teal.widgets_table_with_settings_is_initialized_with_2_buttons_and_a_table
table_with_settings_ui 💚 $4.17$ $-4.16$ e2e_teal.widgets_table_with_settings_the_click_on_expand_button_opens_a_modal_with_a_table
table_with_settings_ui 💚 $4.00$ $-3.98$ e2e_teal.widgets_table_with_settings_the_click_on_the_download_button_opens_a_download_menu_with_file_type_file_name_and_download_button
verbatim_popup_ui 💚 $3.49$ $-3.48$ e2e_teal.widgets_verbatim_popup_is_initialized_with_a_button_that_opens_a_modal_with_a_verbatim_text

Results for commit 38ac91b

♻️ This comment has been updated with latest results.

Copy link
Contributor

@gogonzo gogonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@donyunardi donyunardi merged commit 7ab23b7 into main Aug 14, 2025
26 checks passed
@donyunardi donyunardi deleted the partial_argument_match@main branch August 14, 2025 11:29
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants