Skip to content

fix(collector): cleaned up request objects after agent host lookup #1908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix(collector): cleaned up request objects after agent host lookup #1908

wants to merge 2 commits into from

Conversation

kirrg001
Copy link
Contributor

@kirrg001 kirrg001 commented Aug 4, 2025 •
edited
Loading

Found while investigating #1886

refs https://jsw.ibm.com/browse/INSTA-35539

@kirrg001 kirrg001 force-pushed the fix-destr-req-agentlookup branch from 9fa18bc to 3c21d78 Compare August 18, 2025 11:07
@kirrg001 kirrg001 changed the title fix(collector): destroyed request on error or timeout fix(collector): cleaned up request objects after agent host lookup Aug 18, 2025
@kirrg001 kirrg001 marked this pull request as ready for review August 18, 2025 11:39
@kirrg001 kirrg001 requested a review from a team as a code owner August 18, 2025 11:39
aryamohanan
aryamohanan requested changes Aug 29, 2025
View reviewed changes
Copy link
Contributor

@aryamohanan aryamohanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests appear to be failing on tekton because req.destroy() is being called from test, but this method does not exist on the FakeRequest class.

@kirrg001 kirrg001 marked this pull request as draft September 11, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aryamohanan aryamohanan aryamohanan requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kirrg001 @aryamohanan