-
Notifications
You must be signed in to change notification settings - Fork 36
Possible backwards incompatibility for unathenticated OPeNDAP access #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Happy to do a release here, if that helps |
I think that depends a bit on where you want to go with the If you'd instead like to stay to what is written in the docs, than maybe #62 is not a good idea. Personally I think the first option and a quick new release would be great, but I don't want to spoil other ideas. |
OK, let's wait a bit to hear from the other maintainers. I, personally, am more familiar with the code than with actual usage. |
Agree that tagging a new 0.3.2 release is good (0.3.1 is more than a year old!). It sounds like Option 1 (rewording the manual) would be easiest. Personally I find the current NetCDF driver to be better because it allows for caching (though you're right that it isn't quite intuitive, here's a non-OPeNDAP example), and just use a |
I've opened a potential fix for the docs. While doing this, I came across the default arguments for the How do you think about this? Maybe it is a good idea to change this now as well, such that we break multiple things at once in stead of one after another. |
Cool, thanks for being proactive!
It's been mentioned before at #57 (comment). Technically if no password/username is given, it should fallback to no authentication (i.e. None) according to #57 (comment). But perhaps this should be explicitly |
I can not confirm the behaviour you describe an which was mentioned in 57. When I try to access a dataset where I've removed
and in fact, a subsequent exception is triggered. So the For completeness: I can access the very same dataset if I personally wouldn't care if it is 0.3.2 or 0.4.0, but the latter seems to be a bit more fair to other users :-) |
Apart from historic reasons, using ESGF as the default authentication method does not seem to be a straight forward choice. Changing the default to no authentication most likely is the more user friendly alternative. Apart from that and following intake#57, the default if no authentication method is given should be anonymous access, but currently this fall back does not work (see also intake#74).
I think with the acceptance of #76, it is pretty clear that #62 is here to stay and thus that unauthenticated access to opendap should go via the opendap driver. Furthermore, I think the possibility of having unauthenticated access to opendap via this driver could be retained in future releases independently of how the netcdf driver evolves. This basically answers the original question of this issue 👍 . As far as I see, there are currently two remaining open topics:
In order to advance our catalog (my reason for starting this issue), the actual outcome of these questions is not of great importance, but having the current (and hopefully future) status inside of a released version is essential. So @martindurant what do you think? How can we move this issue forward? |
@martindurant thank you very much for including all the suggested changes. However, there's still one thing remaining in this issue: a new release. Initially you mentioned that this would be easy to do for you, so I am wondering when this would happen. What is the current status on this? Are there other currently open topics which should also be solved prior to a next release? |
Thanks for the ping. v0.3.2 now on pypi |
Perfect, thank you so much! |
We are currently building an intake catalog for a field campaign which refers to several datasets which are accessible via unauthenticated OPeNDAP. One issue that we've come across was that the currently released version (
v0.3.1
) does not yet support unauthenticated access via theopendap
driver (which was introduced in #57). However, it was still possible to access those resources using thenetcdf
driver. For the currentmaster
the situation has turned around, as #62 introduces caching for remotely stored netCDF-files, but that is incompatible with OPeNDAP resources. While I see the usefulness of caching remotely stored netCDF-files, I don't see a way how to properly decide if a URL should be interpreted as downloadable netCDF file or as OPeNDAP resource, so I don't know how to support both, the old and the new behaviour of thenetcdf
driver.So, the question would be how should we proceed when building our intake catalog (i.e use
netcdf
or useopendap
as a driver for unauthenticated OPeNDAP access)? And will we have to fear a breaking change at which point all users must update theirintake-xarray
libraries while we are updating the catalog? The options which I currently see are:intake-xarray
and useopendap
from the beginning.netcdf
from the beginningnetcdf
now andopendap
later, but that would require a coordinated update between catalog creators and all usersThe text was updated successfully, but these errors were encountered: