Skip to content

Conversation

caarlos0
Copy link
Contributor

Heyy!

first code PR on terraform, sorry if its not right!

I tested it by copying the binary inside my plugins folder and changing the lock with the SHA256sum, is there a better way? (besides the make tests and etc).

anyway, it seems to be ok, looking forward for feedback!

cheers!

@radeksimko
Copy link
Contributor

Hi @caarlos0
thanks for the PR, but #51 with the exact same functionality was just merged, so I'm going to have to close this PR too. Sorry!

The good news is that it's going to be part of the next release. 🎉

@radeksimko radeksimko closed this Feb 15, 2018
@radeksimko radeksimko added the Type: Feature New feature or request label Feb 15, 2018
@caarlos0
Copy link
Contributor Author

Hi @caarlos0
thanks for the PR, but #51 with the exact same functionality was just merged, so I'm going to have to close this PR too. Sorry!

np, I haven't seen the other PR, my bad..

Thanks for the great project!

@caarlos0 caarlos0 deleted the require-code-owner-reviews branch February 15, 2018 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants