Skip to content

don't prepend sudo to command if user is superuser #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2024
Merged

don't prepend sudo to command if user is superuser #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions internal/script/script.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ func RunScripts(myTarget target.Target, scripts []ScriptDefinition, ignoreScript
continue
}
if script.Superuser && !canElevate {
slog.Info("skipping script because it requires superuser privileges and the target cannot elevate privileges", slog.String("script", script.Name))
slog.Info("skipping script because it requires superuser privileges and the user cannot elevate privileges on target", slog.String("script", script.Name))
continue
}
if script.Sequential {
Expand Down Expand Up @@ -163,8 +163,12 @@ func RunScripts(myTarget target.Target, scripts []ScriptDefinition, ignoreScript
// instigates a known bug in the terminal that corrupts the tty settings:
// https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1043320
var cmd *exec.Cmd
if needsElevatedPrivileges {
// run master script with sudo, "-S" to read password from stdin
if needsElevatedPrivileges && !canElevate {
// this shouldn't happen because we already filtered out the scripts that require elevated privileges if the user cannot elevate privileges on the target
err = fmt.Errorf("master script requires elevated privileges but the user cannot elevate privileges on target")
return nil, err
} else if needsElevatedPrivileges && !myTarget.IsSuperUser() {
// run master script with sudo, "-S" to read password from stdin. Note: password won't be asked for if password-less sudo is configured.
cmd = exec.Command("sudo", "-S", "bash", path.Join(myTarget.GetTempDirectory(), masterScriptName))
} else {
cmd = exec.Command("bash", path.Join(myTarget.GetTempDirectory(), masterScriptName))
Expand Down
18 changes: 16 additions & 2 deletions internal/target/target.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ type Target interface {
// It returns true if the user can elevate privileges, false otherwise.
CanElevatePrivileges() bool

// IsSuperUser checks if the current user is a superuser.
// It returns true if the user is a superuser, false otherwise.
IsSuperUser() bool

// GetArchitecture returns the architecture of the target system.
// It returns a string representing the architecture and any error that occurred.
GetArchitecture() (arch string, err error)
Expand Down Expand Up @@ -370,7 +374,7 @@ func (t *LocalTarget) CanElevatePrivileges() bool {
if t.canElevate != 0 {
return t.canElevate == 1
}
if os.Geteuid() == 0 {
if t.IsSuperUser() {
t.canElevate = 1
return true // user is root
}
Expand Down Expand Up @@ -406,7 +410,7 @@ func (t *RemoteTarget) CanElevatePrivileges() bool {
if t.canElevate != 0 {
return t.canElevate == 1
}
if t.user == "root" {
if t.IsSuperUser() {
t.canElevate = 1
return true
}
Expand All @@ -420,6 +424,16 @@ func (t *RemoteTarget) CanElevatePrivileges() bool {
return false
}

// IsSuperUser checks if the current user is a superuser.
// It returns true if the user is a superuser, false otherwise.
func (t *LocalTarget) IsSuperUser() bool {
return os.Geteuid() == 0
}

func (t *RemoteTarget) IsSuperUser() bool {
return t.user == "root"
}

// InstallLkms installs the specified LKMs (Loadable Kernel Modules) on the target.
// It returns the list of installed LKMs and any error encountered during the installation process.
func (t *LocalTarget) InstallLkms(lkms []string) (installedLkms []string, err error) {
Expand Down
Loading