Skip to content
This repository was archived by the owner on Aug 25, 2024. It is now read-only.

Replace args and config methods with CONFIG property #164

Open
johnandersen777 opened this issue Aug 13, 2019 · 9 comments · Fixed by #311
Open

Replace args and config methods with CONFIG property #164

johnandersen777 opened this issue Aug 13, 2019 · 9 comments · Fixed by #311
Assignees
Labels
enhancement New feature or request p1 High Priority tM Esitmated Time To Complete: Medium
Milestone

Comments

@johnandersen777
Copy link

johnandersen777 commented Aug 13, 2019

Get ride of args(...) and config(...) methods

Auto args and config was implemented here: 22c0303

Now we have to use it everywhere.

I suggest changing one class then re-running the tests to confirm nothing broke.

@johnandersen777 johnandersen777 added the enhancement New feature or request label Aug 13, 2019
@johnandersen777 johnandersen777 added this to the 0.2.2 Dot Release milestone Aug 13, 2019
@johnandersen777 johnandersen777 changed the title base: BaseConfigureable base: BaseConfigurable simply args and config methods Sep 12, 2019
@johnandersen777 johnandersen777 self-assigned this Nov 4, 2019
@johnandersen777
Copy link
Author

johnandersen777 commented Nov 4, 2019

@johnandersen777
Copy link
Author

johnandersen777 commented Dec 18, 2019

What's left:

  • dffml/df/memory.py
  • source/mysql
    • NOTE Pretty sure _ is not supported yet by the auto args and config. If it is, great, it should take - and make it into _, but it likely will not work. If you have time to fix it great. If not, just figure out one-word versions of the same properties and update the docs.

@johnandersen777 johnandersen777 added p1 High Priority tS Esitmated Time To Complete: Short labels Dec 18, 2019
@johnandersen777 johnandersen777 changed the title base: BaseConfigurable simply args and config methods Replace args and config methods with CONFIG property Dec 18, 2019
@johnandersen777 johnandersen777 added tM Esitmated Time To Complete: Medium and removed tS Esitmated Time To Complete: Short labels Dec 18, 2019
@justinwmoore
Copy link
Contributor

I'd like to work on this issue.

@johnandersen777
Copy link
Author

Hi @Jstar1! Awesome! Thanks! Sorry I missed your IM on Friday. I'd say the best way to get started is to mess with skel first. Once you've got one down post up a WIP: ... or Draft pull request and I'll check it out!

@johnandersen777
Copy link
Author

johnandersen777 commented Jan 3, 2020

@Jstar1 Just wanted to give you a heads up we're run into an issue with the model/scikit stuff so I'm going to try to knock out that bullet. If you we're working on that one just let me know. The other ones should be less problematic.

Edit: Done

@justinwmoore
Copy link
Contributor

@pdxjohnny , just got back from vacation. Thanks for the heads up looks like I won't have to worry about it though.

justinwmoore added a commit to justinwmoore/dffml that referenced this issue Jan 10, 2020
Removes all instances of args and config.

fixes: intel#164
justinwmoore added a commit to justinwmoore/dffml that referenced this issue Jan 10, 2020
Removes all instances of args and config.

fixes: intel#164
justinwmoore added a commit to justinwmoore/dffml that referenced this issue Jan 10, 2020
Removes all instances of args and config.

fixes: intel#164
justinwmoore added a commit to justinwmoore/dffml that referenced this issue Jan 13, 2020
Removes all instances of args and config.

fixes: intel#164
justinwmoore added a commit to justinwmoore/dffml that referenced this issue Jan 13, 2020
Removes all instances of args and config.

fixes: intel#164
@justinwmoore
Copy link
Contributor

justinwmoore commented Jan 14, 2020

@pdxjohnny , is dffml/skel/* complete or did I miss a module?
Also I see that you've closed this issue but dffml/df/memory.py still needs to be completed.

@johnandersen777
Copy link
Author

@Jstar1 Damn man you're up early!!! I accidentally closed it. I also just stumbled across source/mysql which needs doing as well.

@justinwmoore
Copy link
Contributor

haha, @pdxjohnny , yea I'm an earlier riser. You're up pretty early yourself.
I'll continue to work through this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request p1 High Priority tM Esitmated Time To Complete: Medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants