This repository was archived by the owner on Aug 25, 2024. It is now read-only.
types : definition : Add validate to definition #357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnandersen777
suggested changes
Jan 27, 2020
| import inspect | ||
| import pathlib | ||
|
|
||
| import unittest |
There was a problem hiding this comment.
I accidentally removed these when I went through and removed all unused import. The CI wasn't failing... weird. I figured out what was wrong: #358
If you merge master into this branch we'll be good to go.
johnandersen777
suggested changes
Jan 28, 2020
tests/test_types.py
Outdated
|
|
||
|
|
||
| class TestDefintion(AsyncTestCase): | ||
| async def test_validate(self): |
There was a problem hiding this comment.
Let's add another test_ where the pie datatype raises a InputValidationError (add this new error class to dffml/exceptions.py).
Use with self.assertRaises(InputValidationError) in the new test to make sure that we catch it.
aghinsa
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #349