Skip to content
This repository was archived by the owner on Jan 28, 2023. It is now read-only.

Conversation

AlexAltea
Copy link
Contributor

@AlexAltea AlexAltea commented Oct 24, 2018

Based on the discussion at #108 (comment), I've prepared a TravisCI configuration script for HAXM.

This should be extremely helpful to review pull requests. For now it only checks for successful builds, but we can extend it by checking the emulator unit tests, or even integration tests, such as launching a VM (assuming the hardware/hypervisor used in TravisCI servers allows it).

Windows support is very recent (barely two weeks!), and right now they support only Visual Studio 2017 build tools, which apparently is not enough to build HAXM. However I've tested the script locally, and it should work once they provide a proper Visual Studio installation, which is likely. If you want to remove the Windows script in the meantime, let me know (I can add it as a comment to this PR until its ready).

EDIT: It seems https://github.com/intel is already integrated with TravisCI (see badges below). That really helps, and totally makes this choice even more convenient than alternatives (e.g. AppVeyor).

@raphaelning
Copy link
Contributor

Thanks a lot! Indeed this is a great help.

The code looks nice and simple. We can keep the Windows script, but how can we test it locally? It doesn't seem to be written in Batch syntax.

@AlexAltea
Copy link
Contributor Author

AlexAltea commented Oct 25, 2018

We can keep the Windows script, but how can we test it locally? It doesn't seem to be written in Batch syntax.

According to the TravisCI Windows reference, the Windows script is executed within Git BASH (which I am thankful for, considering how terrible cmd.exe is).

Their current environment is essentially a stock Windows Server 2016 installation, with Chocolatey and these preinstalled packages, which include Git BASH. Testing locally, using Windows 10 instead and Visual Studio 2017, that script works for me.

EDIT: Just found a small issue: The Windows script needs to manually fetch packages via nuget.
I will fix it and rebase.

Signed-off-by: Alexandro Sanchez Bach <[email protected]>
@AlexAltea
Copy link
Contributor Author

All done!

@raphaelning
Copy link
Contributor

Cool! I can see in the Travis build log that the macOS build is working :-)

@raphaelning raphaelning requested a review from wcwang October 25, 2018 09:35
@wcwang wcwang merged commit 56f1ee2 into intel:master Oct 29, 2018
@AlexAltea AlexAltea deleted the travis branch October 29, 2018 03:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants