reconciler: incomplete log output

[mythi]

this line

intel-device-plugins-for-kubernetes/pkg/controllers/reconciler.go

Line 233 in d60419e

log.Info("", cmp.Diff(ds0.Spec.Template.Spec, ds.Spec.Template.Spec, diff.IgnoreUnset()))

is causing incomplete log lines that look suspicious especially when the diff is empty:

I0515 14:13:19.142299 1922029 reconciler.go:233] "" controller="dsadeviceplugin" controllerGroup="deviceplugin.intel.com" controllerKind="DsaDevicePlugin" DsaDevicePlugin="dsadeviceplugin-test" namespace="" name=
"dsadeviceplugin-test" reconcileID=d9fa9595-5651-4796-9c6d-75073106860e ="(MISSING)"

[hershpa]

We have observed similar behavior on OpenShift 4.12:

I0524 15:35:03.613495 1 reconciler.go:233] "intel-device-plugins-manager: " controller="sgxdeviceplugin" controllerGroup="deviceplugin.intel.com" controllerKind="SgxDevicePlugin" SgxDevicePlugin="sgxdeviceplugin-sample" namespace="" name="sgxdeviceplugin-sample" reconcileID=a30409d8-f114-415d-87e4-7be8b43e54e3 ="(MISSING)" I0524 15:35:03.613575 1 reconciler.go:233] "intel-device-plugins-manager: " controller="qatdeviceplugin" controllerGroup="deviceplugin.intel.com" controllerKind="QatDevicePlugin" QatDevicePlugin="qatdeviceplugin-sample" namespace="" name="qatdeviceplugin-sample" reconcileID=72caa4a3-4e4e-40a1-8984-96847a09d204 ="(MISSING)" I0524 15:35:03.613687 1 reconciler.go:233] "intel-device-plugins-manager: " controller="gpudeviceplugin" controllerGroup="deviceplugin.intel.com" controllerKind="GpuDevicePlugin" GpuDevicePlugin="gpudeviceplugin-sample" namespace="" name="gpudeviceplugin-sample" reconcileID=51c54915-9f99-47dc-9fe7-bb769a19a4a2 ="(MISSING)" I0524 15:35:03.627115 1 reconciler.go:233] "intel-device-plugins-manager: " controller="qatdeviceplugin" controllerGroup="deviceplugin.intel.com" controllerKind="QatDevicePlugin" QatDevicePlugin="qatdeviceplugin-sample" namespace="" name="qatdeviceplugin-sample" reconcileID=a18294f2-8169-4570-9cb8-d13131b319e0 ="(MISSING)"

[tkatila]

The log.Info function takes pairs of arguments (name & value). The cmp.Diff() should have a name that is before the value. Something like:
log.Info("", "diff", cmp.Diff(ds0.Spec.Template.Spec, ds.Spec.Template.Spec, diff.IgnoreUnset()))

But there are also problems with the individual controllers indicating changes where there isn't any. Like in @hershpa's example: sgx, gpu and qat are all printing this "changed" line even though the Diff() returns empty string (=no changes).

[tkatila]

I revisited this and created a PR which should decrease those prints.

[hershpa]

Thanks @tkatila this will definitely help eliminate unwanted confusion.