assorted fixes #1299
Merged
assorted fixes #1299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikko Ylinen <[email protected]>
Signed-off-by: Mikko Ylinen <[email protected]>
Signed-off-by: Mikko Ylinen <[email protected]>
mythi
requested review from
bart0sh,
ozhuraki,
hj-johannes-lee,
tkatila and
kad
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1299 +/- ##
=======================================
Coverage 51.17% 51.17%
=======================================
Files 44 44
Lines 4879 4879
=======================================
Hits 2497 2497
Misses 2239 2239
Partials 143 143 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tkatila
reviewed
Jan 12, 2023
|
|
||
| if err = e2epod.WaitForPodsRunningReady(c, "node-feature-discovery", 2, 0, | ||
| 100*time.Second, map[string]string{}); err != nil { | ||
| 200*time.Second, map[string]string{}); err != nil { |
There was a problem hiding this comment.
Using proxy/mirror didn't fully fix the e2e issues?
There was a problem hiding this comment.
I'm preparing for another change that makes the spr/gnr instances to run a bit slower.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1284
Fixes: #1277