Skip to content

fpga: reimplement device discovering #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2020

Conversation

bart0sh
Copy link
Member

@bart0sh bart0sh commented Oct 19, 2020

Reimplemented discovering FPGA devices using APIs from pkg/fpga/intel_fpga_linux.
The APis are also used in the fpga_tool utility.

The API is more advanced and supports SR-IOV among other things.

Fixes: #372

@bart0sh bart0sh added the fpga FPGA device plugin related issue label Oct 19, 2020
@bart0sh bart0sh requested review from rojkov, kad and mythi October 19, 2020 16:39
@bart0sh bart0sh marked this pull request as draft October 19, 2020 16:42
@bart0sh bart0sh force-pushed the PR0091-FPGA-SRIO-V branch from afe49a4 to 6f064b5 Compare October 19, 2020 16:53
@bart0sh bart0sh force-pushed the PR0091-FPGA-SRIO-V branch from 6f064b5 to e70968a Compare October 26, 2020 18:12
@bart0sh bart0sh changed the title fpga: reimplement device scanning fpga: reimplement device discovering Oct 26, 2020
@bart0sh bart0sh force-pushed the PR0091-FPGA-SRIO-V branch 2 times, most recently from 8285ce0 to 542e1ab Compare October 26, 2020 19:39
Reimplemented discovering of the FPGA devices using
APIs from pkg/fpga/intel_fpga_linux. The APis are also
used in the fpga_tool utility.

The API is more advanced and supports SR-IOV among other
things.

Fixes: intel#372

Signed-off-by: Ed Bartosh <[email protected]>
@bart0sh bart0sh force-pushed the PR0091-FPGA-SRIO-V branch from 542e1ab to 243870a Compare October 26, 2020 19:46
@codecov-io
Copy link

Codecov Report

Merging #478 into master will decrease coverage by 1.84%.
The diff coverage is 80.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #478      +/-   ##
==========================================
- Coverage   58.27%   56.43%   -1.85%     
==========================================
  Files          30       30              
  Lines        2114     2036      -78     
==========================================
- Hits         1232     1149      -83     
- Misses        814      816       +2     
- Partials       68       71       +3     
Impacted Files Coverage Δ
cmd/fpga_plugin/fpga_plugin.go 69.65% <75.86%> (-8.71%) ⬇️
cmd/fpga_plugin/dfl.go 100.00% <100.00%> (+4.44%) ⬆️
cmd/fpga_plugin/opae.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbab9b3...243870a. Read the comment docs.

@bart0sh bart0sh marked this pull request as ready for review October 26, 2020 20:01
@rojkov rojkov merged commit 25a52b0 into intel:master Oct 30, 2020
@bart0sh bart0sh deleted the PR0091-FPGA-SRIO-V branch June 13, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fpga FPGA device plugin related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FPGA SRIO-V is not supportted by the FPGA device plugin
3 participants