Skip to content

Conversation

hj-johannes-lee
Copy link
Contributor

@hj-johannes-lee hj-johannes-lee commented Mar 25, 2022

Closes: #884
Signed-off-by: Hyeongju Johannes Lee [email protected]

@hj-johannes-lee hj-johannes-lee requested a review from kad as a code owner March 25, 2022 14:48
Copy link
Contributor

@mythi mythi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments about logging and the test case changes.

@mythi
Copy link
Contributor

mythi commented Mar 28, 2022

/cc @ipuustin

@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2022

Codecov Report

Merging #939 (de90344) into main (7598c0d) will increase coverage by 0.36%.
The diff coverage is 80.95%.

❗ Current head de90344 differs from pull request most recent head 8911c89. Consider uploading reports for the commit 8911c89 to get more accurate results

@@            Coverage Diff             @@
##             main     #939      +/-   ##
==========================================
+ Coverage   52.97%   53.34%   +0.36%     
==========================================
  Files          40       40              
  Lines        4232     4291      +59     
==========================================
+ Hits         2242     2289      +47     
- Misses       1870     1878       +8     
- Partials      120      124       +4     
Impacted Files Coverage Δ
pkg/controllers/qat/controller.go 17.64% <0.00%> (-0.24%) ⬇️
cmd/qat_plugin/dpdkdrv/dpdkdrv.go 89.57% <83.60%> (-2.01%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

mythi
mythi previously approved these changes Apr 6, 2022
Signed-off-by: Hyeongju Johannes Lee <[email protected]>
@mythi mythi merged commit 482ed7b into intel:main Apr 7, 2022
@hj-johannes-lee hj-johannes-lee deleted the qat-allocation-policy branch April 13, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

qat: implement preferredAllocation policies
7 participants