Skip to content

qat: 4xxx: split generic resource to compression and crypto #946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2022
Merged

qat: 4xxx: split generic resource to compression and crypto #946

merged 1 commit into from
Apr 8, 2022

Conversation

mythi
Copy link
Contributor

@mythi mythi commented Mar 30, 2022

Closes: #700

/cc @ipuustin

@mythi mythi marked this pull request as ready for review April 5, 2022 18:17
@mythi mythi requested review from rojkov, bart0sh and kad as code owners April 5, 2022 18:17
ozhuraki
ozhuraki previously approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@ozhuraki ozhuraki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ipuustin
ipuustin previously approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@ipuustin ipuustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

hj-johannes-lee
hj-johannes-lee reviewed Apr 6, 2022
View reviewed changes
Copy link
Contributor

@hj-johannes-lee hj-johannes-lee left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(My review is actually to have a better understanding rather than to review..)

  1. Do we not need to change also demo yaml files?
  2. Below

@mythi mythi dismissed stale reviews from ipuustin and ozhuraki via 745cf27 April 7, 2022 07:36
@codecov-commenter
Copy link

Codecov Report

Merging #946 (0189920) into main (7598c0d) will decrease coverage by 0.02%.
The diff coverage is 52.63%.

❗ Current head 0189920 differs from pull request most recent head 745cf27. Consider uploading reports for the commit 745cf27 to get more accurate results

@@            Coverage Diff             @@
##             main     #946      +/-   ##
==========================================
- Coverage   52.97%   52.95%   -0.03%     
==========================================
  Files          40       40              
  Lines        4232     4268      +36     
==========================================
+ Hits         2242     2260      +18     
- Misses       1870     1884      +14     
- Partials      120      124       +4
Impacted Files Coverage Δ
cmd/qat_plugin/dpdkdrv/dpdkdrv.go 85.29% <52.63%> (-6.30%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

ipuustin
ipuustin previously approved these changes Apr 7, 2022
View reviewed changes
@mythi
Copy link
Contributor Author

mythi commented Apr 8, 2022

@bart0sh @rojkov this can be merged if it looks OK

rojkov
rojkov approved these changes Apr 8, 2022
View reviewed changes
Copy link
Contributor

@rojkov rojkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rojkov rojkov merged commit 9a6ad82 into intel:main Apr 8, 2022
@Feelas Feelas mentioned this pull request May 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hj-johannes-lee hj-johannes-lee hj-johannes-lee left review comments

@ozhuraki ozhuraki ozhuraki left review comments

@bart0sh bart0sh Awaiting requested review from bart0sh bart0sh is a code owner

@kad kad Awaiting requested review from kad kad is a code owner

+2 more reviewers

@rojkov rojkov rojkov approved these changes

@ipuustin ipuustin ipuustin left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

qat: 4xxx: split generic resource to compress and crypto
6 participants
@mythi @codecov-commenter @rojkov @ipuustin @ozhuraki @hj-johannes-lee