This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[ESIMD] Add a test to validate new implementation of esimd::fmod #1045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-klochkov
reviewed
Jun 14, 2022
There was a problem hiding this comment.
The test looks good.
I have only one comment: It tests only 1 input pair or values and it is the only test for fmod we have in ESIMD folder. Can you please add more test cases with various signs and reminders.
Something similar to the test cases used here: https://en.cppreference.com/w/cpp/numeric/math/fmod
Fixed |
v-klochkov
previously approved these changes
Jun 14, 2022
|
/verify with intel/llvm#6242 |
v-klochkov
approved these changes
Jun 16, 2022
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
…el#1045) * Add a test to validate new implementation of esimd::fmod
myler
added a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
CMPLRTST-17291: fix the issue ZE_DEBUG=1 will be overwrited by opt_use_gpu_zedebug (ZE_DEBUG=-1)
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…el/llvm-test-suite#1045) * Add a test to validate new implementation of esimd::fmod
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complementary compiler PR intel/llvm#6242