Skip to content

[NFC][SYCL] Initialize class member pointer to nullptr. #10313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 23, 2023
Merged

[NFC][SYCL] Initialize class member pointer to nullptr. #10313

merged 2 commits into from
Aug 23, 2023

Conversation

schittir
Copy link
Contributor

No description provided.

@schittir schittir requested a review from a team as a code owner July 11, 2023 21:19
@schittir schittir temporarily deployed to aws July 11, 2023 21:35 — with GitHub Actions Inactive
@schittir
Copy link
Contributor Author

@tahonermann - could you please take a look at this? Thank you!

@bader
Copy link
Contributor

bader commented Jul 11, 2023

@schittir, this looks like something unrelated to SYCL and should go to directly to review.llvm.org. Am I right?

@schittir
Copy link
Contributor Author

schittir commented Jul 11, 2023 •
edited
Loading

@schittir, this looks like something unrelated to SYCL and should go to directly to review.llvm.org. Am I right?

Hi @bader https://github.com/llvm/llvm-project/blob/main/clang/include/clang/Analysis/CallGraph.h doesn't contain ASTContext *Ctx member, therefore that change belongs with intel/llvm.

However, it does contain https://github.com/llvm/llvm-project/blob/main/clang/include/clang/Analysis/CallGraph.h#L52 CallGraphNode *Root, so, I will move that change to llorg.

@schittir schittir temporarily deployed to aws July 11, 2023 22:41 — with GitHub Actions Inactive
@schittir schittir changed the title [NFC] Initialize class member pointers to nullptr. [NFC] Initialize class member pointer to nullptr. Jul 11, 2023
@schittir schittir temporarily deployed to aws July 11, 2023 22:58 — with GitHub Actions Inactive
@schittir schittir temporarily deployed to aws July 11, 2023 23:36 — with GitHub Actions Inactive
tahonermann
tahonermann approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@tahonermann tahonermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for shuffling these changes through all the systems, Sindhu!

@bader bader changed the title [NFC] Initialize class member pointer to nullptr. [NFC][SYCL] Initialize class member pointer to nullptr. Jul 12, 2023
@schittir
Copy link
Contributor Author

@bader @AaronBallman can this be merged?
Thanks,
Sindhu

@schittir
Copy link
Contributor Author

@intel/llvm-gatekeepers - could you please merge this?

@aelovikov-intel
Copy link
Contributor

aelovikov-intel commented Aug 22, 2023 •
edited
Loading

@intel/llvm-gatekeepers - could you please merge this?

The testing is more than month-old! Please merge in origin/sycl into this PR's branch.

@schittir
Copy link
Contributor Author

schittir commented Aug 22, 2023 •
edited
Loading

@intel/llvm-gatekeepers - could you please merge this?

The testing is more than month-old! Please merge in origin/sycl into this PR's branch.

I accidentally did a git --rebase instead of a merge (habit from committing to llorg), so I had to force push to update this branch. Sorry about that. Nevertheless, this triggered running the tests again. Hope that helps!

@bader bader merged commit e8a5d99 into intel:sycl Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elizabethandrews elizabethandrews elizabethandrews approved these changes

@AaronBallman AaronBallman Awaiting requested review from AaronBallman

@erichkeane erichkeane Awaiting requested review from erichkeane

+2 more reviewers

@tahonermann tahonermann tahonermann approved these changes

@smanna12 smanna12 smanna12 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@schittir @bader @aelovikov-intel @tahonermann @elizabethandrews @smanna12