[mlir] Remove duplicated SingleBlockImplicitTerminator member functions #11136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Upstream PR: llvm/llvm-project#65959 |
sommerlukas
approved these changes
Sep 11, 2023
|
Fixes #11078 |
victor-eds
changed the title
|
Please look into the |
victor-eds
commented
Sep 12, 2023
victor-eds
force-pushed
the
fix-push-back
branch
from
a3930aa to
9cc3532
Compare
|
Just review 9cc35320c1388dea2d7c42560bf0e67bee03d9e6 |
whitneywhtsang
approved these changes
Sep 12, 2023
sommerlukas
reviewed
Sep 12, 2023
There was a problem hiding this comment.
As I told @victor-eds offline, I'm not convinced that std::enable_if_t<!hasSingleBlockImplicitTerminator<OpT> is the right approach here, because it uses the unrelated class SingleBlockImplicitTerminator in the implementation of SingleBlock.
victor-eds
force-pushed
the
fix-push-back
branch
from
9cc3532 to
f8c9c1e
Compare
…herited" trait in ODS instead of C++"" This reverts commit ecfd878. Signed-off-by: Victor Perez <[email protected]>
Change `SingleBlock::{insert,push_back}` to avoid inserting the
argument operation after the block's terminator. This allows removing
`SingleBlockImplicitTerminator`'s functions with the same name.
Define `Block::hasTerminator` checking whether the block has a
terminator operation.
Signed-off-by: Victor Perez <[email protected]>
victor-eds
force-pushed
the
fix-push-back
branch
from
f8c9c1e to
67830fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT SQUASH AND MERGE THIS PR.
Avoid member functions duplication caused by SingleBlockImplicitTerminator now implying SingleBlock (since 0ac21e6). Use
std::enable_ifto provide different definitions topush_backandinsert.