[SYCL][Doc] Move uniform extension spec #11259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The uniform extension was implemented in intel#5871. Move the extension specification document to the "experimental" directory.
This makes sense and matches the implementation.
|
There is one small substantive change. See c90080b. |
Pennycook
reviewed
Sep 21, 2023
sycl/doc/extensions/experimental/sycl_ext_oneapi_uniform.asciidoc
Outdated
Show resolved
Hide resolved
We decided that `sycl::id` should not be a disallowed uniform type. It not allowed to pass a work-item's ID to `uniform` because that value does not have a uniform value for all work-items. However, the application can construct its own `sycl::id` in a uniform way, so we should not disallow `sycl::id` in general. This commit restores the spec wording and also changes the implementation to align with that wording.
gmlueck
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
gmlueck
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Pennycook
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The uniform extension was implemented in #5871. Move the extension
specification document to the "experimental" directory, and update to the
latest specification template.
Also fix a small bug in the implementation. The
sycl::idtype shouldnot be disallowed for use in
uniform. Although, it is invalid topass the work-item's ID to
uniform(because that value is not uniformacross all work-items), the user could construct their own
idthatdoes have a uniform value.