Skip to content

Conversation

asudarsa
Copy link
Contributor

@asudarsa asudarsa commented May 7, 2024

This bug was introduced in #13579
Unfortunately CI testing decided not to run cuda testing for the guilty PR and the PR was merged. This PR resolves the issue.

Thanks

@asudarsa asudarsa requested a review from a team as a code owner May 7, 2024 23:39
@asudarsa asudarsa requested a review from steffenlarsen May 7, 2024 23:39
@asudarsa
Copy link
Contributor Author

asudarsa commented May 7, 2024

Hi @aelovikov-intel

Is it possible to force-run the cuda testing for this PR?

Thanks

@aelovikov-intel
Copy link
Contributor

Hi @aelovikov-intel

Is it possible to force-run the cuda testing for this PR?

Thanks

It should start automatically once Linux Pre-Commit task finishes.

@asudarsa
Copy link
Contributor Author

asudarsa commented May 7, 2024

Hi @aelovikov-intel
Is it possible to force-run the cuda testing for this PR?
Thanks

It should start automatically once Linux Pre-Commit task finishes.

Thanks Andrei
For PR #13579, the cuda testing did not run for some reason. So, I was hoping to see if there is any way to make it run here. I see AMD testing listed in the list of tests, but not Cuda...

@aelovikov-intel
Copy link
Contributor

For PR #13579, the cuda testing did not run for some reason. So, I was hoping to see if there is any way to make it run here. I see AMD testing listed in the list of tests, but not Cuda...

Likely it ran but wasn't reported on the statuses (you'd still have gotten an e-mail with failures though). That issue was supposedly addressed by #13377.

@asudarsa asudarsa temporarily deployed to WindowsCILock May 7, 2024 23:52 — with GitHub Actions Inactive
@asudarsa asudarsa changed the title [SYCL][DeviceLib] Fix bug due to erroneous removal of library build option [SYCL][DeviceLib] Fix bug due to erroneous removal of device library build option May 7, 2024
@asudarsa asudarsa requested a review from againull May 7, 2024 23:58
@steffenlarsen
Copy link
Contributor

Post-commit cleanup failure is unrelated and happens after build succeeded.

@steffenlarsen steffenlarsen merged commit 0e9507c into intel:sycl May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants