Skip to content

[SYCL] Use the system installed vc-intrinsics if available #18206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 29, 2025

Conversation

sarnex
Copy link
Contributor

@sarnex sarnex commented Apr 25, 2025

For all external dependencies, we should try using the system installed one first and only download the repo if we can't find it.

Apply that for vc-intrinics first, I manually tested this with both static and shared library builds.

@sarnex sarnex changed the title [SYCL] Use the sysinstalled vc-intrinsics if available [SYCL] Use the system installed vc-intrinsics if available Apr 25, 2025
Signed-off-by: Sarnie, Nick <[email protected]>
@sarnex sarnex temporarily deployed to WindowsCILock April 28, 2025 14:39 — with GitHub Actions Inactive

# Date: Mar 7, 2025
# Update Triple usage after 979c275097
Copy link
Contributor Author

@sarnex sarnex Apr 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff kinda sucks, all I did is wrap all the existing code in

find_package(LLVMGenXIntrinsics QUIET)
if (NOT LLVMGenXIntrinsics_FOUND)

endif()

@sarnex sarnex temporarily deployed to WindowsCILock April 28, 2025 15:33 — with GitHub Actions Inactive
@sarnex sarnex temporarily deployed to WindowsCILock April 28, 2025 15:44 — with GitHub Actions Inactive
@sarnex sarnex temporarily deployed to WindowsCILock April 28, 2025 15:44 — with GitHub Actions Inactive
@sarnex sarnex marked this pull request as ready for review April 28, 2025 16:07
@sarnex sarnex requested review from a team as code owners April 28, 2025 16:07
@aelovikov-intel
Copy link
Contributor

aelovikov-intel commented Apr 28, 2025

I think it's possible our dev machines could have some obsolete installations. Can we provide an opt-in to download even if there is an installation present?

Or, if the version is important, maybe using the installed an opt-in instead? That would help the folks who requested the change still.

@sarnex
Copy link
Contributor Author

sarnex commented Apr 28, 2025

@aelovikov-intel I don't think we ever installed vc-intrinsics at the system level but sure I can do that

@aelovikov-intel
Copy link
Contributor

@aelovikov-intel I don't think we ever installed vc-intrinsics at the system level but sure I can do that

I expect we'd want to apply the same logic for other dependencies, so even if one of them could have been installed before, it would be a good change.

Signed-off-by: Sarnie, Nick <[email protected]>
@sarnex sarnex temporarily deployed to WindowsCILock April 28, 2025 17:15 — with GitHub Actions Inactive
@sarnex
Copy link
Contributor Author

sarnex commented Apr 28, 2025

@aelovikov-intel We already have two vars to specify custom source/include dirs to use, so I just wrapped the new check to not automatically search if those vars are set.

@sarnex sarnex merged commit fcb33b2 into intel:sycl Apr 29, 2025
36 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants