Skip to content

[SYCL][E2E] Add test demonstrating problems with std::array in device code on Windows #18426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 12, 2025
Merged

[SYCL][E2E] Add test demonstrating problems with std::array in device code on Windows #18426

merged 6 commits into from
May 12, 2025

Conversation

ianayl
Copy link
Contributor

@ianayl ianayl commented May 12, 2025 •
edited by aelovikov-intel
Loading

This PR is meant to accompany #18400: It demonstrates that we currently have compile issues with MSVC when using std::array in device code on windows.

@ianayl ianayl requested a review from a team as a code owner May 12, 2025 19:15
@ianayl ianayl requested a review from steffenlarsen May 12, 2025 19:15
@ianayl ianayl requested a review from aelovikov-intel May 12, 2025 19:15
@ianayl ianayl mentioned this pull request May 12, 2025
Merged
@ianayl ianayl changed the title [SYCL][E2E] Add check for problems with std::array in device code on Windows [SYCL][E2E] Add test demonstrating problems with std::array in device code on Windows May 12, 2025
@ianayl ianayl temporarily deployed to WindowsCILock May 12, 2025 19:56 — with GitHub Actions Inactive
@ianayl ianayl temporarily deployed to WindowsCILock May 12, 2025 20:18 — with GitHub Actions Inactive
@ianayl ianayl temporarily deployed to WindowsCILock May 12, 2025 20:18 — with GitHub Actions Inactive
@ianayl ianayl temporarily deployed to WindowsCILock May 12, 2025 20:47 — with GitHub Actions Inactive
@ianayl ianayl temporarily deployed to WindowsCILock May 12, 2025 21:08 — with GitHub Actions Inactive
@ianayl ianayl temporarily deployed to WindowsCILock May 12, 2025 21:08 — with GitHub Actions Inactive
@aelovikov-intel aelovikov-intel changed the title [SYCL][E2E] Add test demonstrating problems with std::array in device code on Windows [SYCL][E2E] Add test demonstrating problems with std::array in device code on Windows May 12, 2025
@ianayl ianayl temporarily deployed to WindowsCILock May 12, 2025 21:25 — with GitHub Actions Inactive
@ianayl ianayl temporarily deployed to WindowsCILock May 12, 2025 21:48 — with GitHub Actions Inactive
@ianayl ianayl temporarily deployed to WindowsCILock May 12, 2025 21:48 — with GitHub Actions Inactive
@aelovikov-intel
Copy link
Contributor 

Failed Tests (4):
  SYCL :: KernelAndProgram/cache_env_vars.cpp
  SYCL :: KernelAndProgram/cache_env_vars_lin.cpp
  SYCL :: KernelCompiler/opencl.cpp
  SYCL :: KernelCompiler/sycl_cache_pm.cpp

are failing in other PRs and I think I saw someone submitting an issue for that.

@aelovikov-intel aelovikov-intel merged commit c0010e0 into intel:sycl May 12, 2025
23 of 24 checks passed
kbenzie pushed a commit that referenced this pull request May 13, 2025
@ianayl @aelovikov-intel
[SYCL] Provide _invalid_parameter symbol in device code on Windows (#…
570f74d 
…18400)

Provides a fix for #18426: Provides symbols necessary for `std::array`
to work in device code in debug mode on Windows.

---------

Co-authored-by: aelovikov-intel <[email protected]>
KornevNikita pushed a commit that referenced this pull request May 27, 2025
@ianayl @KornevNikita
[SYCL][E2E] Add test demonstrating problems with std::array in devi…
8670b8e 
…ce code on Windows (#18426)

This PR is meant to accompany #18400:
It demonstrates that we currently have compile issues with MSVC when
using `std::array` in device code on windows.
KornevNikita pushed a commit that referenced this pull request May 27, 2025
@ianayl @aelovikov-intel @KornevNikita
[SYCL] Provide _invalid_parameter symbol in device code on Windows (#…
9165104 
…18400)

Provides a fix for #18426: Provides symbols necessary for `std::array`
to work in device code in debug mode on Windows.

---------

Co-authored-by: aelovikov-intel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aelovikov-intel aelovikov-intel aelovikov-intel approved these changes

@steffenlarsen steffenlarsen Awaiting requested review from steffenlarsen steffenlarsen is a code owner automatically assigned from intel/llvm-reviewers-runtime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ianayl @aelovikov-intel