Skip to content

[DeviceSanitizer][NFC] Add comments for initialization of LaunchInfo.Data. #18915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: sycl
Choose a base branch
from

Conversation

haonanya1
Copy link
Contributor

AsanInterceptor::prepareLaunch has this call, which aligns with msan and tsan.

AsanInterceptor::prepareLaunch has this call, which aligns with msan and tsan.
@haonanya1 haonanya1 requested a review from a team as a code owner June 11, 2025 06:38
@haonanya1 haonanya1 requested a review from a team June 11, 2025 06:38
@haonanya1
Copy link
Contributor Author

Found the issue when investigate test failure in opencl cpu runtime.

Copy link
Contributor

@yingcong-wu yingcong-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. There is another sync op inside preLaunchKernel, so this one is indeed duplicated and useless.

@haonanya1
Copy link
Contributor Author

@intel/llvm-gatekeepers, pr is ready to merge. Thank you!

@AllanZyne AllanZyne self-requested a review June 12, 2025 01:53
Copy link
Contributor

@AllanZyne AllanZyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This call is necessary, don't remove it!

@zhaomaosu
Copy link
Contributor

It's better to add comments if it's necessary.

@AllanZyne
Copy link
Contributor

AllanZyne commented Jun 12, 2025

When the kernel is filtered, it's still possible that LaunchInfo is used in kernel code, so the "syncToDevice" here will give it the default value.

To make this PR meaningful, could you help to add a comment to tip others not remove this line?

@yingcong-wu
Copy link
Contributor

It's better to add comments if it's necessary.

I agree. If this is necessary, then the code should be commented for its necessity to avoid such problem.

Copy link
Contributor

@yingcong-wu yingcong-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comment from @AllanZyne and do not remove this line.

@haonanya1 haonanya1 changed the title [DeviceSanitizer] Remove duplicated syncToDevice call. [DeviceSanitizer][NFC] Add comments for initialization of LaunchInfo.Data. Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants