Skip to content

Conversation

KornevNikita
Copy link
Contributor

@KornevNikita KornevNikita commented Jun 12, 2025

@KornevNikita KornevNikita requested a review from a team as a code owner June 12, 2025 08:52
@aelovikov-intel
Copy link
Contributor

aelovikov-intel commented Jun 12, 2025

On a second thought, should we revert the guilty patch instead?

@KornevNikita , @againull

@KornevNikita
Copy link
Contributor Author

On a second thought, should we revert the guilty patch instead?

@KornevNikita , @againull

Not sure if it's implementation or test issue. @againull ?

@againull
Copy link
Contributor

againull commented Jun 12, 2025

On a second thought, should we revert the guilty patch instead?
@KornevNikita , @againull

Not sure if it's implementation or test issue. @againull ?

Actually, it turned out that failure is caused by #18710 (not by #18735) but not because of the problem with the patch per se, but because it exposed another issue, I am working on a fix.
Also necessary to mention that there seem to be 2 problems in that event cts test:

2025-06-12T04:15:47.6758689Z /__w/llvm/llvm/khronos_sycl_cts/tests/event/event.cpp:278
2025-06-12T04:15:47.6758770Z ...............................................................................
2025-06-12T04:15:47.6758773Z 
2025-06-12T04:15:47.6758952Z /__w/llvm/llvm/khronos_sycl_cts/tests/event/event.cpp:294: FAILED:
2025-06-12T04:15:47.6759016Z   CHECK( teh1.count() == 1 )
2025-06-12T04:15:47.6759072Z with expansion:
2025-06-12T04:15:47.6759121Z   0 == 1
2025-06-12T04:15:47.6759124Z 
2025-06-12T04:15:47.6759244Z /__w/llvm/llvm/khronos_sycl_cts/tests/event/event.cpp:295: FAILED:
2025-06-12T04:15:47.6759310Z   CHECK( teh1.has("some-error") )
2025-06-12T04:15:47.6759362Z with expansion:
2025-06-12T04:15:47.6759412Z   false
2025-06-12T04:15:47.6759416Z 
2025-06-12T04:15:47.6759513Z -------------------------------------------------------------------------------
2025-06-12T04:15:47.6759646Z event::wait_and_throw reports asynchronous errors from related events on
2025-06-12T04:15:47.6759701Z corresponding queues
2025-06-12T04:15:47.6759800Z -------------------------------------------------------------------------------
2025-06-12T04:15:47.6759901Z /__w/llvm/llvm/khronos_sycl_cts/tests/event/event.cpp:278
2025-06-12T04:15:47.6759987Z ...............................................................................
2025-06-12T04:15:47.6759991Z 
2025-06-12T04:15:47.6760105Z /__w/llvm/llvm/khronos_sycl_cts/tests/event/event.cpp:294: FAILED:
2025-06-12T04:15:47.6760163Z   CHECK( teh1.count() == 1 )
2025-06-12T04:15:47.6760219Z with expansion:
2025-06-12T04:15:47.6760266Z   0 == 1
2025-06-12T04:15:47.6760269Z 
2025-06-12T04:15:47.6760383Z /__w/llvm/llvm/khronos_sycl_cts/tests/event/event.cpp:295: FAILED:
2025-06-12T04:15:47.6760446Z   CHECK( teh1.has("some-error") )
2025-06-12T04:15:47.6760501Z with expansion:
2025-06-12T04:15:47.6760547Z   false
2025-06-12T04:15:47.6760585Z 
2025-06-12T04:15:47.6760687Z -------------------------------------------------------------------------------
2025-06-12T04:15:47.6760799Z event::get_backend_info returns backend-specific information
2025-06-12T04:15:47.6760895Z -------------------------------------------------------------------------------
2025-06-12T04:15:47.6760996Z /__w/llvm/llvm/khronos_sycl_cts/tests/event/event.cpp:360
2025-06-12T04:15:47.6761078Z ...............................................................................
2025-06-12T04:15:47.6761081Z 
2025-06-12T04:15:47.6761198Z /__w/llvm/llvm/khronos_sycl_cts/tests/event/event.cpp:360: FAILED:
2025-06-12T04:15:47.6761256Z explicitly with message:
2025-06-12T04:15:47.6761327Z   This test case is not yet implemented.
2025-06-12T04:15:47.6761331Z 
2025-06-12T04:15:47.6761427Z -------------------------------------------------------------------------------
2025-06-12T04:15:47.6761505Z event::get_profiling_info works as expected
2025-06-12T04:15:47.6761603Z -------------------------------------------------------------------------------
2025-06-12T04:15:47.6761697Z /__w/llvm/llvm/khronos_sycl_cts/tests/event/event.cpp:371
2025-06-12T04:15:47.6761782Z ...............................................................................
2025-06-12T04:15:47.6761785Z 
2025-06-12T04:15:47.6761896Z /__w/llvm/llvm/khronos_sycl_cts/tests/event/event.cpp:403: FAILED:
2025-06-12T04:15:47.6761965Z   CHECK( submit_time <= start_time )
2025-06-12T04:15:47.6762019Z with expansion:
2025-06-12T04:15:47.6762076Z   209660731885 (0x30d0c0e1ed)
2025-06-12T04:15:47.6762122Z   <=
2025-06-12T04:15:47.6762178Z   209659642816 (0x30d0b043c0)
2025-06-12T04:15:47.6762181Z 

It seems that my changes have caused CHECK( submit_time <= start_time ) but not other errors. When running locally I see failures like this CHECK( teh1.count() == 1 ) even with older compilers.

@againull againull merged commit c2c2022 into intel:sycl Jun 12, 2025
7 checks passed
@KornevNikita
Copy link
Contributor Author

@againull other errors are not errors actually, they are expected by the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants