Skip to content

[UR][Offload] Fix to make offload adapter compile #19040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2025
Merged

[UR][Offload] Fix to make offload adapter compile #19040

merged 1 commit into from
Jun 18, 2025

Conversation

RossBrunton
Copy link
Contributor

@RossBrunton RossBrunton commented Jun 18, 2025 •
edited
Loading

No description provided.

@RossBrunton RossBrunton requested a review from a team as a code owner June 18, 2025 10:34
@RossBrunton RossBrunton requested a review from callumfare June 18, 2025 10:36
@RossBrunton
Copy link
Contributor Author

RossBrunton commented Jun 18, 2025 •
edited
Loading

@intel/llvm-gatekeepers This can't affect Cuda, Hip, Level Zero or Native CPU, so this should be clear to merge despite the CI failure (#19033)

Ignore that, forgot I already did this in #18957

@RossBrunton RossBrunton marked this pull request as draft June 18, 2025 12:47
@RossBrunton RossBrunton changed the title [UR][Offload] Fixes to make offload adapter compile [UR][Offload] Fix to make offload adapter compile Jun 18, 2025
@RossBrunton RossBrunton marked this pull request as ready for review June 18, 2025 13:40
@RossBrunton
Copy link
Contributor Author

Failure is known as #19047 and this MR doesn't affect SYCL code (we don't build SYCL with offload yet).

@intel/llvm-gatekeepers please merge.

@kbenzie
Copy link
Contributor

kbenzie commented Jun 18, 2025

There's still unfinished jobs.

@dm-vodopyanov
Copy link
Contributor

Waiting for SYCL Pre Commit on Windows / build / Build + LIT (pull_request) completion

@dm-vodopyanov dm-vodopyanov merged commit e84de94 into intel:sycl Jun 18, 2025
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@callumfare callumfare callumfare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RossBrunton @kbenzie @dm-vodopyanov @callumfare