[sycl-post-link] Improve spec constants pattern recognition #3360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1113d0a changes addrspacecast instruction generation. This impacts the pattern recognition if LLVM IR is not optimized before SpecConstantsPass. Now both load and store instructions accepting cast pointer instead of a pointer produced by alloca instruction. This change make pattern recognition to support both versions of LLVM IR.
AlexeySachkov
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1113d0a changes addrspacecast
instruction generation. This impacts the pattern recognition if LLVM IR
is not optimized before SpecConstantsPass. Now both load and store
instructions accepting cast pointer instead of a pointer produced by
alloca instruction.
This change make pattern recognition to support both versions of LLVM
IR.