Skip to content

[SYCL][NFC] Resolve cyclic dependency in headers #5419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2022
Merged

[SYCL][NFC] Resolve cyclic dependency in headers #5419

merged 1 commit into from
Jan 29, 2022

Conversation

bader
Copy link
Contributor

@bader bader commented Jan 28, 2022

This change breaks sycl.hpp <- fpga_device_selector.hpp <- sycl.hpp
cycle of includes.

@bader
[SYCL][NFC] Resolve cyclic dependency in headers
c4b303e 
This change breaks sycl.hpp <- fpga_device_selector.hpp <- sycl.hpp
cycle of includes.
@bader bader requested a review from a team as a code owner January 28, 2022 16:46
@bader bader requested review from s-kanaev and romanovvlad January 28, 2022 16:46
@bader bader merged commit d866c24 into intel:sycl Jan 29, 2022
@bader bader deleted the cycle-deps branch January 29, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanovvlad romanovvlad Awaiting requested review from romanovvlad

1 more reviewer

@s-kanaev s-kanaev s-kanaev approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bader @s-kanaev