Skip to content

[SYCL][NFC] Fix warnings after compile-time properties implementation #5684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2022
Merged

[SYCL][NFC] Fix warnings after compile-time properties implementation #5684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sycl/include/sycl/ext/oneapi/properties/properties.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ struct ExtractProperties<std::tuple<PropertiesTs...>> {

template <typename... PropertyValueTs>
static ExtractedPropertiesT<PropertyValueTs...>
Extract(std::tuple<PropertyValueTs...> PropertyValues) {
Extract(std::tuple<PropertyValueTs...>) {
return {};
}
};
Expand Down
8 changes: 4 additions & 4 deletions sycl/include/sycl/ext/oneapi/properties/property_value.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,16 +51,16 @@ struct property_value
template <typename PropertyT, typename... A, typename... B>
constexpr std::enable_if_t<detail::IsCompileTimeProperty<PropertyT>::value,
bool>
operator==(const property_value<PropertyT, A...> &LHS,
const property_value<PropertyT, B...> &RHS) {
operator==(const property_value<PropertyT, A...> &,
const property_value<PropertyT, B...> &) {
return (std::is_same<A, B>::value && ...);
}

template <typename PropertyT, typename... A, typename... B>
constexpr std::enable_if_t<detail::IsCompileTimeProperty<PropertyT>::value,
bool>
operator!=(const property_value<PropertyT, A...> &LHS,
const property_value<PropertyT, B...> &RHS) {
operator!=(const property_value<PropertyT, A...> &,
const property_value<PropertyT, B...> &) {
return (!std::is_same<A, B>::value || ...);
}

Expand Down