-
Notifications
You must be signed in to change notification settings - Fork 802
[sycl-post-link] Remove padding from DeviceGlobalProperty #5848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As it is described in [1], MemorySanitizer emits an unexpected report about an uninitialized value when we are reading a structure with padding as a byte array. The patch implements a workaround: the type of the DeviceImageScope flag has been replaced with uint32_t to not require a space for padding. The change should have no impact on performance and ABI because the size is the same. [1] llvm/llvm-project#54476
|
8 bytes is the size of the data plus 8 bytes is the size of the size field. Co-authored-by: Steffen Larsen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Mikhail Lychkov <[email protected]>
I've opened a ticket for the |
As it is described in [1], MemorySanitizer emits an unexpected report
about an uninitialized value when we are reading a structure with
padding as a byte array. The patch implements a workaround:
the type of the DeviceImageScope flag has been replaced with uint32_t
to not require a space for padding. The change should have no impact
on performance and ABI because the size is the same.
[1] llvm/llvm-project#54476