[SYCL] Fix depends_on handling with pi commands #5901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
…up of blocked commands) Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
KseniyaTikhomirova
force-pushed
the
default_dependson
branch
from
b45914e to
1238b1e
Compare
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
KseniyaTikhomirova
changed the title
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
KseniyaTikhomirova
force-pushed
the
default_dependson
branch
from
7c2bab3 to
78643fc
Compare
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
|
@sergey-semenov , @s-kanaev , @romanovvlad , hi, folks, could you please review since you know almost all context for this change? |
KseniyaTikhomirova
requested review from
sergey-semenov,
s-kanaev and
romanovvlad
alexbatashev
reviewed
Apr 5, 2022
s-kanaev
reviewed
Apr 5, 2022
romanovvlad
reviewed
Apr 6, 2022
sycl/source/detail/event_impl.cpp
Outdated
Comment on lines
331
to
334
| else if (MCommand) | ||
| return sycl::info::event_command_status::submitted; | ||
| } | ||
| return MHostEvent && MState.load() != HES_Complete |
There was a problem hiding this comment.
Would it be the same if we just return submitted if MState.load() != HES_Complete?
There was a problem hiding this comment.
yes, now MHostEvent check seems to be redundant here, thanks.
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
KseniyaTikhomirova
requested review from
romanovvlad,
alexbatashev and
s-kanaev
sergey-semenov
previously approved these changes
Aug 25, 2022
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
sergey-semenov
approved these changes
Aug 30, 2022
|
@intel/llvm-gatekeepers this commit is ready to merge, could you help please? |
KseniyaTikhomirova
added a commit
to KseniyaTikhomirova/llvm
that referenced
this pull request
Sep 6, 2022
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
steffenlarsen
pushed a commit
that referenced
this pull request
Sep 13, 2022
Cross dependency event_impl vs queue_impl prevents objects release. Event_impl now has only weak pointer to queue. Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two related issues:
AddDep always call processDepEvent which distributes events to MPreparedDepsEvents (pi event expected) and MPreparedHostDepsEvents (no pi event) so replacement of MDeps in enqueueCommand should be valid.