[SYCL] Add buffer_allocator SYCL 2020 conformant variant #6200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes makes `buffer_allocator` a template class taking the data type of the associated buffer. Likewise it changes the default allocator used by buffer to be `buffer_allocator<std::remove_const_t<T>>`. Since these changes are API breaking they are only applied if SYCL2020_CONFORMANT_APIS is defined. Signed-off-by: Larsen, Steffen <[email protected]>
|
/verify with intel/llvm-test-suite#1039 |
aelovikov-intel
previously approved these changes
May 26, 2022
Signed-off-by: Larsen, Steffen <[email protected]>
pvchupin
approved these changes
May 27, 2022
|
/verify with intel/llvm-test-suite#1039 |
|
Failure in DeprecatedFeatures/buffer_interop.cpp is expected to be fixed with #6214. I will rerun verification once that is merged. |
|
/verify with intel/llvm-test-suite#1039 |
|
Failure in Basic/queue/release.cpp is a known sporadic failure and is unrelated. |
aelovikov-intel
approved these changes
Jun 1, 2022
pvchupin
pushed a commit
to intel/llvm-test-suite
that referenced
this pull request
Jun 3, 2022
Adds a test for buffer_allocator for both the SYCL 1.2.1 variant and the SYCL 2020 variant (guarded by SYCL2020_CONFORMANT_APIS.) This tests intel/llvm#6200. Signed-off-by: Larsen, Steffen <[email protected]>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
) Adds a test for buffer_allocator for both the SYCL 1.2.1 variant and the SYCL 2020 variant (guarded by SYCL2020_CONFORMANT_APIS.) This tests intel#6200. Signed-off-by: Larsen, Steffen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes makes
buffer_allocatora template class taking the data type of the associated buffer. Likewise it changes the default allocator used by buffer to bebuffer_allocator<std::remove_const_t<T>>. Since these changes are API breaking they are only applied if SYCL2020_CONFORMANT_APIS is defined.