[SYCL] Add support for assert in windows NVPTX #6215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until cxx standard library for NVPTX extension is implemented `_wassert` is provided by libclc, that passes it to a call to `__assertfail`.
jchlanda
force-pushed
the
jakub/wassert_dll_import_2
branch
from
af3f2a3 to
da5ae63
Compare
smanna12
reviewed
May 31, 2022
smanna12
reviewed
May 31, 2022
| // expect to see any warnings or compilation errors. On Windows targeting NVPTX | ||
| // the implementation of assert is provided by libclc. | ||
| // | ||
| // Please note, that the execution of the assert is tested in llvm-test-suite. |
There was a problem hiding this comment.
If this functionality is being tested in the test suite and we no longer have FE changes, I don't think we need FE tests. Can you explain why you added this test? I'm not sure if I am missing something.
There was a problem hiding this comment.
I agree with @elizabethandrews. If #6188 is not needed, then our (my) request for FE tests is no longer relevant. Is that what prompted you to add FE tests?
There was a problem hiding this comment.
Yeap, it was.
I'll remove the test. One thing to note is that the test suite will require a bit of work to support asserts on windows/hip.
|
+1 for removing FE tests. I'd rather let it go without tests than with tests in unrelated place. |
aelovikov-intel
approved these changes
Jun 1, 2022
smanna12
approved these changes
Jun 1, 2022
elizabethandrews
approved these changes
Jun 1, 2022
premanandrao
approved these changes
Jun 1, 2022
pvchupin
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until cxx standard library for NVPTX extension is implemented
_wassertis providedby libclc, that passes it to a call to
__assertfail.Fixes #5922