Skip to content

[ESIMD] Make esimd implementation of fmod compatible with std::fmod #6242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 22, 2022
Merged

[ESIMD] Make esimd implementation of fmod compatible with std::fmod #6242

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
88df143
Make esimd implementation of fmod compatible with std::fmod
fineg74 Jun 3, 2022
49c709e
Fix an issue that results in incorrect results in some cases
fineg74 Jun 14, 2022
d485589
Better handle sign propagation
fineg74 Jun 16, 2022
77528eb
fix clang-format issue
fineg74 Jun 16, 2022
0f75bd3
Optimize implementation per PR comments
fineg74 Jun 18, 2022
38dfb10
fix clang-format issues
fineg74 Jun 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions sycl/include/sycl/ext/intel/experimental/esimd/math.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1371,22 +1371,25 @@ template <> ESIMD_INLINE float atan2(float y, float x) {
template <int N>
ESIMD_INLINE __ESIMD_NS::simd<float, N> fmod(__ESIMD_NS::simd<float, N> y,
__ESIMD_NS::simd<float, N> x) {
__ESIMD_NS::simd<int, N> v_quot;
__ESIMD_NS::simd<float, N> fmod;
__ESIMD_NS::simd<float, N> abs_x = __ESIMD_NS::abs(x);
__ESIMD_NS::simd<float, N> abs_y = __ESIMD_NS::abs(y);
auto fmod_sign_mask = (y.template bit_cast_view<int32_t>()) & 0x80000000;

v_quot = convert<int>(y / x);
fmod = y - x * convert<float>(v_quot);
return fmod;
__ESIMD_NS::simd<float, N> reminder =
abs_y - abs_x * __ESIMD_NS::trunc<float>(abs_y / abs_x);

abs_x.merge(0.0, reminder >= 0);
__ESIMD_NS::simd<float, N> fmod = reminder + abs_x;
__ESIMD_NS::simd<float, N> fmod_abs = __ESIMD_NS::abs(fmod);

auto fmod_bits =
(fmod_abs.template bit_cast_view<int32_t>()) | fmod_sign_mask;
return fmod_bits.template bit_cast_view<float>();
}

// For Scalar Input
// For Scalar Input
template <> ESIMD_INLINE float fmod(float y, float x) {
int v_quot;
__ESIMD_NS::simd<float, 1> fmod;

v_quot = (int)(y / x);
fmod = y - x * v_quot;
return fmod[0];
return fmod(__ESIMD_NS::simd<float, 1>(y), __ESIMD_NS::simd<float, 1>(x))[0];
}

// sin_emu - EU emulation for sin(x)
Expand Down