[SYCL] Handle nullptr arguments in level_zero #6464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-klochkov
force-pushed
the
esimd_spec_const_arg_nullptr
branch
2 times, most recently
from
23016a8 to
ba0df83
Compare
If specialization constant is not used on device, then the buffer for it is not created on device side. In this case the host part passes nullptr for the corresponding kernel operand holding the reference to the buffer with constants. This patch fixes the level_zero arguments handling to avoid SegFault in the plugin. Signed-off-by: Vyacheslav N Klochkov <[email protected]>
Signed-off-by: Vyacheslav N Klochkov <[email protected]>
smaslov-intel
approved these changes
Jul 25, 2022
|
The only fail is "SYCL :: regression/abs_fix_test.cpp". It is unrelated and is a known issue that is resolved recently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If specialization constant is not used on device, then the buffer for
it is not created on device side. In this case the host part passes nullptr
for the corresponding kernel operand holding the reference to the buffer
with constants.
This patch fixes the level_zero arguments handling to avoid SegFault
in the plugin.
Signed-off-by: Vyacheslav N Klochkov [email protected]