Skip to content

[SYCL][libdevice] Add check that ccache is not being used #7761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 13, 2022
Merged

[SYCL][libdevice] Add check that ccache is not being used #7761

merged 2 commits into from
Dec 13, 2022

Conversation

hdelan
Copy link
Contributor

@hdelan hdelan commented Dec 13, 2022 •
edited
Loading

If ccache was being used, this cmake check would set gcc_bin_dir to /usr/lib/ccache and gcc_install_dir to /usr/lib.

This would cause build failures due to missing headers. See PR #7628 and comment #7628 (comment)

@hdelan hdelan requested a review from a team as a code owner December 13, 2022 13:24
@hdelan hdelan changed the title Add check that ccache is not being used [SYCL][libdevice] Add check that ccache is not being used Dec 13, 2022
@hdelan hdelan mentioned this pull request Dec 13, 2022
Merged
@aelovikov-intel
Copy link
Contributor

LGTM , but let's get @pvchupin 's approval as well.

@pvchupin pvchupin merged commit 4c203bb into intel:sycl Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KseniyaTikhomirova KseniyaTikhomirova Awaiting requested review from KseniyaTikhomirova KseniyaTikhomirova is a code owner automatically assigned from intel/llvm-reviewers-runtime

1 more reviewer

@pvchupin pvchupin pvchupin approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hdelan @aelovikov-intel @pvchupin