[SYCL] Rename cluster_group to fixed_size_group #8978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Brodman <[email protected]>
|
This PR seems to be missing the file "partitioned_group.hpp". |
Signed-off-by: James Brodman <[email protected]>
gmlueck
approved these changes
Apr 6, 2023
There was a problem hiding this comment.
I'm not sure of the timeline for this change. I'm approving, but you might want to wait for @Pennycook to return in case he has suggestions on a better name.
Signed-off-by: James Brodman <[email protected]>
steffenlarsen
approved these changes
Apr 12, 2023
Signed-off-by: James Brodman <[email protected]>
Signed-off-by: James Brodman <[email protected]>
jbrodman
changed the title
|
Failed Tests (1): |
steffenlarsen
added a commit
that referenced
this pull request
Apr 24, 2023
- Remove __builtin_unreachable() - Suppress warnings about unused parameters for host device - Rename cluster_group in end-to-end tests (see #8978) --------- Signed-off-by: John Pennycook <[email protected]> Co-authored-by: Larsen, Steffen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames the experimental "cluster_group" as "fixed_size_group". We needed to reclaim the name for future extension purposes.