Skip to content

[ESIMD] Reenable the thread_id test after CI was updated #9037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2023
Merged

[ESIMD] Reenable the thread_id test after CI was updated #9037

merged 1 commit into from
Apr 12, 2023

Conversation

fineg74
Copy link
Contributor

@fineg74 fineg74 commented Apr 12, 2023

No description provided.

@fineg74 fineg74 requested a review from a team as a code owner April 12, 2023 06:10
@fineg74 fineg74 temporarily deployed to aws April 12, 2023 06:38 — with GitHub Actions Inactive
@fineg74 fineg74 temporarily deployed to aws April 12, 2023 06:46 — with GitHub Actions Inactive
@v-klochkov v-klochkov changed the title [SYCL][ESIMD] Reenable the test after CI was updated [ESIMD] Reenable the thread_id test after CI was updated Apr 12, 2023
@v-klochkov v-klochkov merged commit 5fa0560 into intel:sycl Apr 12, 2023
@bader
Copy link
Contributor

bader commented Apr 12, 2023

@v-klochkov, please, do not merge unvalidated changes!
I suspect this change will break the pre-commit checks. If so, please, revert ASAP.

@bader
Copy link
Contributor

bader commented Apr 12, 2023

The test fails on Linux. See https://github.com/intel/llvm/actions/runs/4679913898/jobs/8291106986.
Please, fix ASAP. The right fix should be like this - 82d17df.

v-klochkov added a commit that referenced this pull request Apr 12, 2023
@v-klochkov
Revert "[ESIMD] Reenable the thread_id test after CI was updated (#9037…
3688883 
…)"

This reverts commit 5fa0560.
@v-klochkov v-klochkov mentioned this pull request Apr 12, 2023
Merged
@v-klochkov
Copy link
Contributor

@v-klochkov, please, do not merge unvalidated changes! I suspect this change will break the pre-commit checks. If so, please, revert ASAP.

@bader - I saw 8 passed checks and no fails, then merged. 2 tasks did not start, I thought it was normal, my fault.
Do you know why they did not start? How to initiate those tasks/runs if they refused to start initially?

@v-klochkov
Copy link
Contributor

@v-klochkov, please, do not merge unvalidated changes! I suspect this change will break the pre-commit checks. If so, please, revert ASAP.

@bader - I saw 8 passed checks and no fails, then merged. 2 tasks did not start, I thought it was normal, my fault. Do you know why they did not start? How to initiate those tasks/runs if they refused to start initially?

Revert is in this PR: #9046

@bader
Copy link
Contributor

bader commented Apr 12, 2023

Do you know why they did not start? How to initiate those tasks/runs if they refused to start initially?

See error messages here - https://github.com/intel/llvm/actions/runs/4675184536
The branch must be re-based.

steffenlarsen pushed a commit that referenced this pull request Apr 12, 2023
@v-klochkov @bader
Revert "[ESIMD] Reenable the thread_id test after CI was updated" (#9046
ffe97b9 
)

Reverts #9037

---------

Co-authored-by: Alexey Bader <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-klochkov v-klochkov v-klochkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fineg74 @bader @v-klochkov