[SYCL][L0] Heuristically reduce overhead from immediate command-list cleanup #9052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cleanup Signed-off-by: Sergey V Maslov <[email protected]>
jandres742
reviewed
Apr 13, 2023
| size_t Iter = 0; | ||
| for (auto it = EventList.rbegin(); it != EventList.rend(); ++Iter) { | ||
| if (!EventCompleted(*it)) { | ||
| if (Bisect > 1 && Iter < 3) { // Heuristically limit by 3 checks |
There was a problem hiding this comment.
do we have experimental data showing this is the best limit value?
There was a problem hiding this comment.
not really, but with 3 checks we check most (3/4) of the list, which looked to be enough
againull
approved these changes
Apr 13, 2023
jandres742
pushed a commit
to jandres742/llvm
that referenced
this pull request
Apr 21, 2023
intel#9052 Signed-off-by: Jaime Arteaga <[email protected]>
jandres742
pushed a commit
to jandres742/llvm
that referenced
this pull request
Apr 24, 2023
intel#9052 Signed-off-by: Jaime Arteaga <[email protected]>
jandres742
pushed a commit
to jandres742/llvm
that referenced
this pull request
May 3, 2023
intel#9052 Signed-off-by: Jaime Arteaga <[email protected]>
jandres742
pushed a commit
to jandres742/llvm
that referenced
this pull request
May 16, 2023
intel#9052 Signed-off-by: Jaime Arteaga <[email protected]>
jandres742
pushed a commit
to jandres742/llvm
that referenced
this pull request
May 23, 2023
intel#9052 Signed-off-by: Jaime Arteaga <[email protected]>
jandres742
pushed a commit
to jandres742/llvm
that referenced
this pull request
May 26, 2023
intel#9052 Signed-off-by: Jaime Arteaga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.