Skip to content

Conversation

elizabethandrews
Copy link
Contributor

Do not emit 'final' keyword on forward declaration of classes in integration header.

Do not emit 'final' keyword on forward declaration of
classes in integration header.
@elizabethandrews elizabethandrews requested a review from a team as a code owner April 17, 2023 18:55
@elizabethandrews elizabethandrews temporarily deployed to aws April 17, 2023 21:08 — with GitHub Actions Inactive
@elizabethandrews elizabethandrews temporarily deployed to aws April 17, 2023 22:34 — with GitHub Actions Inactive
Copy link
Contributor

@premanandrao premanandrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nvm, missed the "CHECK".

@elizabethandrews elizabethandrews temporarily deployed to aws April 19, 2023 21:44 — with GitHub Actions Inactive
@elizabethandrews elizabethandrews temporarily deployed to aws April 19, 2023 23:09 — with GitHub Actions Inactive
@elizabethandrews elizabethandrews temporarily deployed to aws April 20, 2023 20:06 — with GitHub Actions Inactive
@elizabethandrews elizabethandrews temporarily deployed to aws April 21, 2023 00:07 — with GitHub Actions Inactive
@elizabethandrews
Copy link
Contributor Author

@intel/llvm-gatekeepers can this PR be merged? The fails seem like infrastructure issues - the tests didn't even run. They did however run and pass on the previous commit. Latest commit is just a merge commit for recent changes

@elizabethandrews elizabethandrews temporarily deployed to aws April 25, 2023 08:36 — with GitHub Actions Inactive
@elizabethandrews elizabethandrews temporarily deployed to aws April 25, 2023 08:36 — with GitHub Actions Inactive
@steffenlarsen steffenlarsen merged commit 9eeb782 into intel:sycl Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants