[SYCL] [L0] Recycle immediate command lists for queues in a context. #9409
+117
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smaslov-intel
approved these changes
May 18, 2023
Co-authored-by: smaslov-intel <[email protected]>
| test(sycl::property_list{}); | ||
|
|
||
| // CHECK: [getZeQueue]: create queue {{.*}} priority = Normal | ||
| // CHECK-STD: [getZeQueue]: create queue {{.*}} priority = Normal |
There was a problem hiding this comment.
Please either add a CHECK-IMM or a comment why it shouldn't be here.
There was a problem hiding this comment.
CHECK-IMM is not needed here precisely because of IMM recycling.
I've added a comment saying so.
Comment on lines
3
to
4
| // RUN: env ZE_DEBUG=1 env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=0 %{run} %t.out 2>&1 | FileCheck %s --check-prefixes=CHECK-STD | ||
| // RUN: env ZE_DEBUG=1 env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=1 %{run} %t.out 2>&1 | FileCheck %s --check-prefixes=CHECK-IMM |
There was a problem hiding this comment.
Suggested change
| // RUN: env ZE_DEBUG=1 env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=0 %{run} %t.out 2>&1 | FileCheck %s --check-prefixes=CHECK-STD | |
| // RUN: env ZE_DEBUG=1 env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=1 %{run} %t.out 2>&1 | FileCheck %s --check-prefixes=CHECK-IMM | |
| // RUN: env ZE_DEBUG=1 SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=0 %{run} %t.out 2>&1 | FileCheck %s --check-prefixes=CHECK-STD | |
| // RUN: env ZE_DEBUG=1 SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=1 %{run} %t.out 2>&1 | FileCheck %s --check-prefixes=CHECK-IMM | |
aelovikov-intel
approved these changes
May 22, 2023
jandres742
pushed a commit
to jandres742/llvm
that referenced
this pull request
May 23, 2023
intel#9409 Signed-off-by: Jaime Arteaga <[email protected]>
jandres742
pushed a commit
to jandres742/llvm
that referenced
this pull request
May 26, 2023
intel#9409 Signed-off-by: Jaime Arteaga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache immediate command lists in a context when a queue is released, Then reuse them for other queues created in that context.
Waiting until context deletion to delete immediate command lists could possibly exhaust device memory when many queues are created and destroyed within the same context.