[SYCL][FPGA][NFC] Refactor of memory attribute tests #9441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch
i. updates tests for FPGA Memory Attributes below:
[[intel::numbanks()]]
[[intel::force_pow2_depth()]]
[[intel::bankwidth()]]
[[intel::max_replicates()]]
[[intel::bank_bits()]]
[[intel::private_copies()]]
[[intel::merge("mrg1", "depth")]]
[[intel::merge("mrg2", "width")]]
[[intel::fpga_register]]
[[intel::fpga_memory("MLAB")]]
[[intel::fpga_memory("BLOCK_RAM")]]
[[intel::doublepump]]
[[intel::singlepump]]
[[intel::simple_dual_port]]
ii. separates AST and diagnostics to make it easier to
read/follow-up/debug in future.
ii. removes duplicate test cases.
iii. no compiler change.
Signed-off-by: Soumi Manna <[email protected]>
elizabethandrews
approved these changes
May 15, 2023
numbank attribute with bank_bits attribute
premanandrao
approved these changes
May 16, 2023
|
Thank you for reviews @premanandrao and @elizabethandrews. |
|
@intel/llvm-gatekeepers This PR is ready to merge. Thank you I am not sure why Jerkins/Precommit is failing. I have rebased my patch but it does not help me much. The patch just updates tests, NFC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch
i. updates tests for FPGA Memory Attributes below:
[[intel::numbanks()]]
[[intel::force_pow2_depth()]]
[[intel::bankwidth()]]
[[intel::max_replicates()]]
[[intel::bank_bits()]]
[[intel::private_copies()]]
[[intel::merge("mrg1", "depth")]]
[[intel::merge("mrg2", "width")]]
[[intel::fpga_register]]
[[intel::fpga_memory("MLAB")]]
[[intel::fpga_memory("BLOCK_RAM")]]
[[intel::doublepump]]
[[intel::singlepump]]
[[intel::simple_dual_port]]
ii. separates AST and diagnostics to make it easier to read/follow-up/debug in future.
ii. removes duplicate test cases.
iii. no compiler change.