[SYCL] Implement sycl_ext_oneapi_device_architecture on host for Level Zero and OpenCL #9843

dm-vodopyanov · 2023-06-13T13:22:49Z

This patch introduces new host API for
sycl_ext_oneapi_device_architecture extension and implements it, currently only for Level Zero and OpenCL

Depends on

…nd OpenCL This patch introduces new host API for sycl_ext_oneapi_device_architecture extension and implements it, currently only for Level Zero and OpenCL Depends on oneapi-src/unified-runtime#573

sycl/plugins/level_zero/CMakeLists.txt

sycl/include/sycl/ext/oneapi/experimental/device_architecture.hpp

sycl/test-e2e/DeviceArchitecture/device_architecture_on_host.cpp

sycl/doc/extensions/experimental/sycl_ext_oneapi_device_architecture.asciidoc

sycl/include/sycl/ext/oneapi/experimental/device_architecture.hpp

AlexeySachkov · 2023-06-13T14:42:33Z

@intel/sycl-language-enabling-triage: FYI

dm-vodopyanov · 2023-06-13T15:10:20Z

Currently the compilation fails because of many unrelated to this patch API breaks in Unified Runtime (this patch updates Unified Runtime, because the small change merged to Unified Runtime is needed here), so need to update Unified Runtime in the separate patch and try to fix these API breaks in it.

…RSION This should have been an obvious update of Unified Runtime sources to support UR_DEVICE_INFO_IP_VERSION, required in intel#9843, but this update brought many API breaks mostly caused by this patch: oneapi-src/unified-runtime#536

devops/dependencies.json

sycl/include/sycl/detail/pi.h

sycl/include/sycl/ext/oneapi/experimental/device_architecture.hpp

sycl/test-e2e/DeviceArchitecture/device_architecture_on_host.cpp

jandres742 · 2023-06-14T23:13:52Z

sycl/plugins/unified_runtime/ur/adapters/level_zero/ur_level_zero_device.cpp

@@ -388,6 +388,8 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(
        uint32_t{1});
  case UR_DEVICE_INFO_GLOBAL_MEM_CACHE_SIZE:
    return ReturnValue(uint64_t{Device->ZeDeviceCacheProperties->cacheSize});
+  case UR_DEVICE_INFO_IP_VERSION:


changes in L0 files look good.

sycl/source/detail/device_info.hpp

This patch updates Level Zero Loader to version v1.11.0 because the previous version does not support implementation of oneapi-src/level-zero-spec#23 Level Zero extension, required for implementing sycl_ext_oneapi_device_architecture on host Addresses intel#9843 (comment)

This patch updates Level Zero Loader to version v1.11.0 because the previous version does not support implementation of oneapi-src/level-zero-spec#23 Level Zero extension, required for implementing sycl_ext_oneapi_device_architecture on host Addresses #9843 (comment)

dm-vodopyanov · 2023-06-20T14:25:13Z

After #9873 is merged, this PR will be updated with the recent changes from intel/llvm, and info about Level Zero loader will be removed from PR description.

Current failures in pre-commit are due to #9873 is not merged yet.

dm-vodopyanov · 2023-06-30T09:45:43Z

The driver on Windows CI machines seems to have been updated, but we still have device IP == 0 in pre-commit.
@jandres742 could you please check, does https://www.intel.com/content/www/us/en/download/726609/intel-arc-iris-xe-graphics-whql-windows.html have the implementation for device IP Level Zero/OpenCL extension?

Meanwhile, I will mark the test as XFAIL on Windows, so when we will get proper driver on Windows CI machines, the test started to pass, and we can enable it for Windows.

dm-vodopyanov · 2023-06-30T13:11:03Z

All failures are unrelated.

SYCL Pre Commit / Linux / SYCL E2E on Intel CPU/GEN9 GPU (pull_request_target)

Failed Tests (1):
  SYCL :: ESIMD/accessor_local.cpp

SYCL Pre Commit / Linux / HIP AMDGPU LLVM Test Suite (pull_request_target)

Failed Tests (5):
  SYCL :: Basic/span.cpp
  SYCL :: USM/memops2d/copy2d_device_to_host.cpp
  SYCL :: USM/memops2d/copy2d_host_to_device.cpp
  SYCL :: USM/memops2d/memcpy2d_device_to_host.cpp
  SYCL :: USM/memops2d/memcpy2d_host_to_device.cpp

SYCL Pre Commit / Linux / [AWS] CUDA LLVM Test Suite (pull_request_target)
SYCL Pre Commit / Windows / L0 GEN12 LLVM Test Suite (pull_request_target)

Failed Tests (1):
  SYCL :: ESIMD/api/functional/operators/operator_assignment_glb_mask.cpp

jandres742 · 2023-07-03T05:47:59Z

The driver on Windows CI machines seems to have been updated, but we still have device IP == 0 in pre-commit. @jandres742 could you please check, does https://www.intel.com/content/www/us/en/download/726609/intel-arc-iris-xe-graphics-whql-windows.html have the implementation for device IP Level Zero/OpenCL extension?

Meanwhile, I will mark the test as XFAIL on Windows, so when we will get proper driver on Windows CI machines, the test started to pass, and we can enable it for Windows.

@dm-vodopyanov Windows drivers are usually behind in terms of L0 version. We would have to wait for next release.

…RSION (intel#9873) This should have been an obvious update of Unified Runtime tag to support UR_DEVICE_INFO_IP_VERSION, required in intel#9843 (just tag update, nothing else), but it also brought many API breaks caused by this patch: oneapi-src/unified-runtime#536. So the current PR updates our codebase in accordance with changed UR API. --------- Signed-off-by: Dmitry Vodopyanov <[email protected]> Co-authored-by: Callum Fare <[email protected]> Co-authored-by: Jaime Arteaga <[email protected]>

…l Zero and OpenCL (intel#9843) This patch introduces new host API for sycl_ext_oneapi_device_architecture extension and implements it, currently only for Level Zero and OpenCL Depends on - oneapi-src/unified-runtime#573 - intel#9873 - intel#9979 - intel#10054

…RSION (intel#9873) This should have been an obvious update of Unified Runtime tag to support UR_DEVICE_INFO_IP_VERSION, required in intel#9843 (just tag update, nothing else), but it also brought many API breaks caused by this patch: oneapi-src/unified-runtime#536. So the current PR updates our codebase in accordance with changed UR API. --------- Signed-off-by: Dmitry Vodopyanov <[email protected]> Co-authored-by: Callum Fare <[email protected]> Co-authored-by: Jaime Arteaga <[email protected]>

…RSION (#9873) This should have been an obvious update of Unified Runtime tag to support UR_DEVICE_INFO_IP_VERSION, required in intel/llvm#9843 (just tag update, nothing else), but it also brought many API breaks caused by this patch: oneapi-src#536. So the current PR updates our codebase in accordance with changed UR API. --------- Signed-off-by: Dmitry Vodopyanov <[email protected]> Co-authored-by: Callum Fare <[email protected]> Co-authored-by: Jaime Arteaga <[email protected]>

…RSION (#9873) This should have been an obvious update of Unified Runtime tag to support UR_DEVICE_INFO_IP_VERSION, required in intel/llvm#9843 (just tag update, nothing else), but it also brought many API breaks caused by this patch: #536. So the current PR updates our codebase in accordance with changed UR API. --------- Signed-off-by: Dmitry Vodopyanov <[email protected]> Co-authored-by: Callum Fare <[email protected]> Co-authored-by: Jaime Arteaga <[email protected]>

…RSION (#9873) This should have been an obvious update of Unified Runtime tag to support UR_DEVICE_INFO_IP_VERSION, required in intel/llvm#9843 (just tag update, nothing else), but it also brought many API breaks caused by this patch: oneapi-src#536. So the current PR updates our codebase in accordance with changed UR API. --------- Signed-off-by: Dmitry Vodopyanov <[email protected]> Co-authored-by: Callum Fare <[email protected]> Co-authored-by: Jaime Arteaga <[email protected]>

[SYCL] Implement sycl_ext_oneapi_device_architecture for Level Zero a…

cbc0f8e

…nd OpenCL This patch introduces new host API for sycl_ext_oneapi_device_architecture extension and implements it, currently only for Level Zero and OpenCL Depends on oneapi-src/unified-runtime#573

dm-vodopyanov requested review from a team as code owners June 13, 2023 13:22

dm-vodopyanov requested a review from againull June 13, 2023 13:22

dm-vodopyanov temporarily deployed to aws June 13, 2023 13:31 — with GitHub Actions Inactive

dm-vodopyanov commented Jun 13, 2023

View reviewed changes

sycl/plugins/level_zero/CMakeLists.txt Outdated Show resolved Hide resolved

sycl/include/sycl/ext/oneapi/experimental/device_architecture.hpp Outdated Show resolved Hide resolved

sycl/test-e2e/DeviceArchitecture/device_architecture_on_host.cpp Show resolved Hide resolved

dm-vodopyanov changed the title ~~[SYCL] Implement sycl_ext_oneapi_device_architecture for Level Zero and OpenCL~~ [SYCL] Implement sycl_ext_oneapi_device_architecture on host for Level Zero and OpenCL Jun 13, 2023

Update unified-runtime tag to support UR_DEVICE_INFO_IP_VERSION

811f8b3

dm-vodopyanov temporarily deployed to aws June 13, 2023 13:52 — with GitHub Actions Inactive

gmlueck reviewed Jun 13, 2023

View reviewed changes

dm-vodopyanov mentioned this pull request Jun 14, 2023

[SYCL][UR] Update Unified Runtime tag to support UR_DEVICE_INFO_IP_VERSION #9873

Merged