This repository was archived by the owner on Aug 5, 2022. It is now read-only.
Fail to read/write if register number is not parsed correctly #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible that a user will provide a register number in a format that strtoul() can't parse. strtoul() will return 0 if it fails to parse a value. The msr-tools will then silently read/write to MSR 0x0 and succeed. At best this may confuse the user, or at worst this will unintentionally write bad data to the system. Check that the register number parsing has succeeded. If it fails, then inform the user, give a suggestion, and exit. Signed-off-by: Yazen Ghannam <[email protected]>
|
This patch works (thanks!), but I'd suggest changing the error message to drop the "Do you need a prefix?" part. I can imagine the confusion from a user doing this: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible that a user will provide a register number in a format
that strtoul() can't parse. strtoul() will return 0 if it fails to parse
a value. The msr-tools will then silently read/write to MSR 0x0 and
succeed. At best this may confuse the user, or at worst this will
unintentionally write bad data to the system.
Check that the register number parsing has succeeded. If it fails, then
inform the user, give a suggestion, and exit.
Signed-off-by: Yazen Ghannam [email protected]