This repository was archived by the owner on Aug 5, 2022. It is now read-only.
Change installation directory back to historical location #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds manpages for wrmsr, rdmsr, and msr-cpuid. These manpages originally come from Debian (where I wrote them almost a decade ago). I've updated them slightly for more recent changes to msr-tools. Signed-off-by: Andres Salomon <[email protected]>
Older versions of msr-tools had the following Makefile snippets:
sbindir = /usr/sbin
install: all
install -m 755 $(BIN) $(sbindir)
That's (in my opinion, at least) the proper location for these tools.
They require superuser privileges, and are tickling CPU registers. Thus,
they belong in /usr/sbin along with other administration utilities.
However, when msr-tools switched to using autotools, the installation
directory changed to /usr/bin. This patch changes it back to installing
into /usr/sbin.
Signed-off-by: Andres Salomon <[email protected]>
|
Please let me know if you need me to make any changes to make this suitable for merging! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older versions of msr-tools had the following Makefile snippets:
sbindir = /usr/sbin
install: all$(BIN) $ (sbindir)
install -m 755
That's (in my opinion, at least) the proper location for these tools.
They require superuser privileges, and are tickling CPU registers. Thus,
they belong in /usr/sbin along with other administration utilities.
However, when msr-tools switched to using autotools, the installation
directory changed to /usr/bin. This patch changes it back to installing
into /usr/sbin.