Release model proto after we have the serialized string to reduce peak memory consumption #672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
@intbf Kindly fix the merge conflicts |
preetha-intel
approved these changes
Apr 25, 2025
intbf
force-pushed
the
release_model_proto_before_compile
branch
2 times, most recently
from
9ef552b to
07f29fe
Compare
…k memory consumption Signed-off-by: bfilipek <[email protected]>
intbf
force-pushed
the
release_model_proto_before_compile
branch
from
07f29fe to
05296fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once we have the serialized string, we can remove the proto object from memory
Description
Call the reset, as in the "else" statement
Motivation and Context
Reduces the peak memory consumption by roughly 1x model size
https://jira.devtools.intel.com/browse/VGD-26545