Fix sqlx macro expansion: set working directory for proc macro expander process
#8271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlad20012
force-pushed
the
macro-target-dir
branch
from
05987cc to
d78ad67
Compare
|
bors r+ |
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
Jan 31, 2022
8489: Update `ra_ap_proc_macro_srv` to `0.0.94`, fix disk usage, fix pwd r=vlad20012 a=vlad20012 This update consists of rust-lang/rust-analyzer#11365, rust-lang/rust-analyzer#11353 and rust-lang/rust-analyzer#11356 PRs Fixes #7709 Fixes #8238 in a proper way (#8271 was a hacky hotfix) changelog: Don't fill up disk space by proc macro DLLs on Windows Co-authored-by: vlad20012 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8238
sqlxmacros write files totarget/sqlxdirectory by a relative path. It expects that PWD is set to the directory withtarget(andCargo.toml) file. In this PR I hotfixed it by settingCARGO_TARGET_DIRenv var. I also set PWD to a temporary directory (it's not currently possible to set PWD to different directories for different proc macros, this required changes in rust-analyzer).changelog: Fix expansion of
sqlxprocedural macros withofflinefeature